Real db support for block query #5459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkase
changed the title
bkase
force-pushed
the
feature/db-queries
branch
from
67b41bc to
f803b70
Compare
mrmr1993
reviewed
Jul 22, 2020
|
Having internet issues so I can’t push — note to reviewers. I made all changes suggested by @mrmr1993 and it is much nicer with the pk joins. |
mrmr1993
reviewed
Jul 22, 2020
| * it is important to select only the block on the canonical chain for a | ||
| * given height, and not an arbitrary one. | ||
| * | ||
| * This query recursively traverses the blockchain from the longest tip |
mrmr1993
approved these changes
Jul 22, 2020
Note: This only tests with the coinbase internal command. But hey at least we know the block and internal command queries work which is cool.
* Comment on recursive query * Explicit projection of sql fields * INNER JOIN all the public keys
bkase
force-pushed
the
feature/db-queries
branch
from
f7ae44a to
7054b70
Compare
bkase
added
ready-to-merge-into-develop
ci-build-me
bkase
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't try to imagine all the code I wrote but then deleted because I realized it could be done better.
All the queries are hooked together and it runs with the
./block.shintest/with the blocks that are generated in dev mode that only contain coinbases.Further testing will follow when more work is put into the testing harness for this thing