Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upload logs for unit tests #5345

Merged
merged 23 commits into from
Jul 24, 2020
Merged

upload logs for unit tests #5345

merged 23 commits into from
Jul 24, 2020

Conversation

ghost-not-in-the-shell
Copy link
Contributor

@ghost-not-in-the-shell ghost-not-in-the-shell commented Jul 10, 2020 •
edited
Loading

This PR makes

  1. unit test uploading core_dumps if test fails
  2. archive node integration test uploading build_logs and test_logs

Close #5333 #5250

@ghost-not-in-the-shell ghost-not-in-the-shell requested a review from a team as a code owner July 10, 2020 19:11
@ghost-not-in-the-shell ghost-not-in-the-shell added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Jul 10, 2020
bkase
bkase approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@bkase bkase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like Buildkite understands this!

@ghost-not-in-the-shell
Copy link
Contributor Author

It seems like Buildkite understands this!

Currently it's not uploading any artifacts because I haven't done the shared volume in the container to share the artifact directory.

@netlify
Copy link

netlify bot commented Jul 20, 2020

Preview:

Built with commit ecee186

https://deploy-preview-5345--o1website2.netlify.app

@ghost-not-in-the-shell ghost-not-in-the-shell added the ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR label Jul 23, 2020
@ghost-not-in-the-shell ghost-not-in-the-shell merged commit 30401f9 into develop Jul 24, 2020
@ghost-not-in-the-shell ghost-not-in-the-shell deleted the buildkite/upload-artifact-for-unit-tests branch July 24, 2020 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkase bkase bkase approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buildkite CI: Add log artifact collection to archive + all jobs
2 participants
@ghost-not-in-the-shell @bkase