[develop] Fix logic in the rosetta integration test #16590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is consistent with compatible. The test will also never work if we don't produce blocks. We should fix that instead.
|
!ci-build-me |
|
!ci-nightly-me |
|
Nightly run here: https://buildkite.com/o-1-labs-2/mina-end-to-end-nightlies/builds/3307 |
|
!ci-build-me |
|
!ci-nightly-me |
|
Nightly run here: https://buildkite.com/o-1-labs-2/mina-end-to-end-nightlies/builds/3308 |
dkijania
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverses one of the erroneous changes made between
compatibleanddevelopas part of #15935.This doesn't fix the test, due to other issues introduced in
developdescribed in #16551. However, this has the effect of shortening the failing test runs significantly by triggering an early failure, rather than repeatedly waiting 90 minutes for a timeout (e.g. here). This is a subset of the changes in #16549, which proposes one possible solution to fully fix the test.