Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Well-formedness check #13266

Merged
merged 8 commits into from
Jun 2, 2023
Merged

Well-formedness check #13266

merged 8 commits into from
Jun 2, 2023

Conversation

psteckler
Copy link
Member

For user commands, add check_well_formedness, which looks for:

  • insufficient fee
  • too-big zkApps
  • zero vesting period in updates to account timing

Call that check when:

  • transactions are added to the pool
  • gossiped blocks are received
  • transactions are submitted via GraphQL

Create unit tests for the zero-vesting-period detection.

Closes #13264. Supersedes #13254.

Probably fixes #13249.

@psteckler psteckler requested a review from a team as a code owner May 24, 2023 22:59
@psteckler
Copy link
Member Author

!ci-build-me

mrmr1993
mrmr1993 approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@mrmr1993 mrmr1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic changes LGTM, but see nits

@psteckler
Copy link
Member Author

!ci-build-me

@psteckler psteckler mentioned this pull request May 24, 2023
Closed
@psteckler
Copy link
Member Author

!ci-build-me

@psteckler
Copy link
Member Author

!ci-build-me

@psteckler
Copy link
Member Author

!ci-build-me

@psteckler
Copy link
Member Author

!ci-build-me

@psteckler
Copy link
Member Author

!ci-build-me

@psteckler
Copy link
Member Author

!ci-build-me

@psteckler psteckler mentioned this pull request Jun 1, 2023
Merged
@deepthiskumar
Copy link
Member

!approved-for-mainnet

@deepthiskumar deepthiskumar merged commit 523b3da into berkeley Jun 2, 2023
@deepthiskumar deepthiskumar deleted the feature/well-formedness-check branch June 2, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmr1993 mrmr1993 mrmr1993 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psteckler @deepthiskumar @mrmr1993