Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move zkapp_uri to Zkapp_account #12008

Merged
merged 10 commits into from
Nov 2, 2022
Merged

Move zkapp_uri to Zkapp_account #12008

merged 10 commits into from
Nov 2, 2022

Conversation

psteckler
Copy link
Member

@psteckler psteckler commented Oct 19, 2022 •
edited
Loading

zkapp_uri is only of relevance if an account has a zkapp field, so move it to Zkapp_account.

Its type remains string.

Closes #11868.

The type linter failures all have to do with zkApp types or V2 types, so benign.

@psteckler psteckler added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Oct 26, 2022
@psteckler psteckler marked this pull request as ready for review October 27, 2022 22:00
@psteckler psteckler requested review from a team as code owners October 27, 2022 22:00
@psteckler
Copy link
Member Author

!ci-build-me

@mrmr1993 mrmr1993 merged commit fdd4242 into develop Nov 2, 2022
@mrmr1993 mrmr1993 deleted the fix/mv-zkapp-uri branch November 2, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmr1993 mrmr1993 mrmr1993 approved these changes

@MartinMinkov MartinMinkov MartinMinkov approved these changes

Assignees
No one assigned
Labels
berkeley-rampup ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move zkapp_uri to zkapp_account
4 participants
@psteckler @mrmr1993 @MartinMinkov @mitschabaude