Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly exposes pending coinbase aux #11785

Merged
merged 6 commits into from
Sep 21, 2022
Merged

Properly exposes pending coinbase aux #11785

merged 6 commits into from
Sep 21, 2022

Conversation

bkase
Copy link
Member

@bkase bkase commented Sep 7, 2022

Explain your changes:

  • Accidentally exposed the pendingCoinbaseHash in the last PR when expecting the pending coinbase aux
  • Kept the pendingCoinbaseHash too

Explain how you tested your changes:

  • If it compiles, it works

@bkase bkase requested review from a team as code owners September 7, 2022 14:12
@bkase bkase added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Sep 7, 2022
@ylecornec
Copy link
Collaborator

The following could be added to src/graphql-ppx-config.inc so that graphql_ppx will decode the type automatically later.

-custom-field
PendingCoinbaseAuxHash
Graphql_lib.Scalars.PendingCoinbaseAuxHash

@bkase bkase merged commit e4a75d6 into develop Sep 21, 2022
@bkase bkase deleted the properly-expose-pending-coinbase-aux branch September 21, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmr1993 mrmr1993 mrmr1993 approved these changes

@mitschabaude mitschabaude mitschabaude approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bkase @ylecornec @mrmr1993 @mitschabaude