Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump ledger depth #11651

Merged
merged 7 commits into from
Nov 4, 2022
Merged

Bump ledger depth #11651

merged 7 commits into from
Nov 4, 2022

Conversation

mrmr1993
Copy link
Member

No description provided.

@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Aug 11, 2022
@psteckler
Copy link
Member

That's a huge difference, allowing 34 billion accounts. Is it needed?

bkase
bkase approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@bkase bkase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We chatted about this and it seems like it adds a negligible amount of overhead and it is possible that this hardfork is the last time we can ever change it without really big disruptions down the line.

@deepthiskumar deepthiskumar added the P0 Urgent label Aug 30, 2022
@mrmr1993 mrmr1993 requested a review from a team as a code owner October 31, 2022 15:24
@mrmr1993
Copy link
Member Author

!ci-build-me

@mrmr1993 mrmr1993 self-assigned this Oct 31, 2022
@mrmr1993
Copy link
Member Author

!ci-build-me

@mrmr1993
Copy link
Member Author

mrmr1993 commented Nov 2, 2022

!ci-build-me

1 similar comment
@mrmr1993
Copy link
Member Author

mrmr1993 commented Nov 2, 2022

!ci-build-me

@mrmr1993
Copy link
Member Author

mrmr1993 commented Nov 3, 2022

!ci-build-me

@mrmr1993 mrmr1993 merged commit eb4de3f into develop Nov 4, 2022
@mrmr1993 mrmr1993 deleted the feature/bump-ledger-depth branch November 4, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkase bkase bkase approved these changes

@nholland94 nholland94 nholland94 approved these changes

Assignees

@mrmr1993 mrmr1993

Labels
berkeley-rampup ci-build-me Add this label to trigger a circle+buildkite build for this branch P0 Urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mrmr1993 @psteckler @bkase @nholland94 @deepthiskumar