Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable payments using zkApp accounts #11331

Merged
merged 21 commits into from
Jul 25, 2022

Conversation

deepthiskumar
Copy link
Member

@deepthiskumar deepthiskumar commented Jun 20, 2022

Explain your changes:

Enabling Payments, Stake delegations, Fee transfers, Coinbase transactions on zkApp accounts. Any of these old-style transactions are applied only if the account allows sending, receiving, and/or setting delegates based on the update performed on the account. In the case of failures, the transaction is included with Failed status- Update_not_permitted_balance.
Fee transfers and coinbase transactions (internal commands) can now fail with these errors and is reflected in the status (it was always Applied before this). For accounts participating in internal commands that don't permit receiving (permission other than None), the tokens to be sent to them are burned.
The application statuses of internal commands are added to staged ledger diff as well.

Explain how you tested your changes:

Checklist:

  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@deepthiskumar deepthiskumar requested a review from a team as a code owner June 20, 2022 19:11
@deepthiskumar deepthiskumar added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Jun 20, 2022
@deepthiskumar deepthiskumar requested a review from a team as a code owner June 21, 2022 05:26
@deepthiskumar deepthiskumar changed the title (WIP) Enable payments using zkApp accounts Enable payments using zkApp accounts Jun 21, 2022
Copy link
Member

@mrmr1993 mrmr1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊 Looks great! Thanks for all of the test cases too, really good to have all of these cases explicitly tested

@deepthiskumar deepthiskumar merged commit 6d92566 into develop Jul 25, 2022
@deepthiskumar deepthiskumar deleted the fix/payments-using-zkapp-accounts branch July 25, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update old transaction logic to handle snapp accounts & permissions correctly
3 participants