Use text columns for OCaml unsigned 64-bit values #11037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psteckler
added
the
ci-build-me
mrmr1993
approved these changes
May 20, 2022
| | [ s ] -> | ||
| (Currency.Amount.of_string s, Sgn.Pos) | ||
| | [ _; s ] -> | ||
| (Currency.Amount.of_string s, Sgn.Neg) |
There was a problem hiding this comment.
Nit: sanity-check with a literal pattern ""?
bkase
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the archive database, for columns representing OCaml unsigned 64-bit ints, use the Postgresql
texttype, to prevent any possibility of overflow. We retain thebiginttype for values representing unsigned 32-bit values (slots and nonces).Update the replayer and extract-blocks apps accordingly. For the replayer test data, ran
ALTER COLUMN .. TYPE texton the affected columns, made sure the test succeeded locally.Tested by running a local network, making sure payments and a zkApp were archived.
Part of #9182.