Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require a valid proof for genesis blocks #10001

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

mrmr1993
Copy link
Member

This PR skips the proof verification check for the genesis block when it's sent by another peer. Currently, nodes will send a dummy proof with the genesis block, and will then be banned by the receiving node.

Note that the node(s) that produce the first block will generate a genesis proof, which they will recursively verify in that block. It is never otherwise useful to generate and distribute a genesis proof, so we avoid doing so by removing this check.

This should fix some flakiness that we've been seeing in integration tests due to nodes banning eachother.

Checklist:

  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Jan 10, 2022
@mrmr1993 mrmr1993 requested a review from a team as a code owner January 10, 2022 21:27
@mrmr1993 mrmr1993 merged commit 708dc86 into develop Jan 11, 2022
@mrmr1993 mrmr1993 deleted the feature/no-send-genesis-proof branch January 11, 2022 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants