Don't require a valid proof for genesis blocks #10001
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR skips the proof verification check for the genesis block when it's sent by another peer. Currently, nodes will send a dummy proof with the genesis block, and will then be banned by the receiving node.
Note that the node(s) that produce the first block will generate a genesis proof, which they will recursively verify in that block. It is never otherwise useful to generate and distribute a genesis proof, so we avoid doing so by removing this check.
This should fix some flakiness that we've been seeing in integration tests due to nodes banning eachother.
Checklist: