Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#434 [feat] 글 삭제/수정 권한 조회 변경 #435

Merged
merged 3 commits into from
Jul 28, 2024
Merged

Conversation

parkheeddong
Copy link
Contributor

✒️ 관련 이슈번호

Key Changes 🔑

  1. 내용
    글 삭제, 수정 권한 로직 변경하였습니다 !

글모임장인 동시에 글 작성자인 경우는 글 작성자로 표기되도록 하기 위해, if문의 순서를 글모임 회원 확인 > 글 작성자 확인 > 글 모임장 확인으로 하였습니다.

@parkheeddong parkheeddong requested a review from sohyundoh July 24, 2024 16:04
@parkheeddong parkheeddong self-assigned this Jul 24, 2024
@parkheeddong parkheeddong changed the title #434 [feat] 권한 조회 변경 #434 [feat] 글 삭제/수정 권한 조회 변경 Jul 24, 2024
Copy link
Member

@sohyundoh sohyundoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!
기존 API를 수정하신 것 같은데, 혹시 Controller는 수정하지 않으셨나요??

@parkheeddong
Copy link
Contributor Author

parkheeddong commented Jul 25, 2024

네! 기존 API에서 권한조회 로직과 DTO만 변경했습니다!

@sohyundoh
Copy link
Member

네! 기존 API에서 권한조회 로직과 DTO만 변경했습니다!

그렇다면, Controller의 메서드 반환타입을 제네릭으로 설정해주는것이 좋을 것 같습니다 :)

@parkheeddong parkheeddong requested a review from sohyundoh July 28, 2024 08:35
Copy link
Member

@sohyundoh sohyundoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 머지하시구, 슬랙으로 웨비들한테 노티드리면 좋을 것 같아요 :)

@parkheeddong parkheeddong merged commit cbdb63a into develop Jul 28, 2024
1 check passed
@parkheeddong parkheeddong deleted the feat/#434 branch July 28, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

[feat] 글 삭제/수정권한 API 변경
2 participants