Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate equality operator and hashCode functions for route args #1338

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

loregr
Copy link

@loregr loregr commented Jan 27, 2023

Problem

args are not included in the equality operator and hashCode functions of PageRouteInfo, this means that when comparing two routes (in particular in a mocked testing environment), we are not able to differentiate routes with different args.

Solution

Generate the equality operator and hashCode functions for each RouteArg, and ensure that args are part of the PageRouteInfo equality checks. The proposed implementation follows the same approach of freezed package when comparing objects or collection of objects.

@loregr
Copy link
Author

loregr commented Feb 9, 2023

@Milad-Akarie mate, just wondering if there's any plan to have this (and the other PRs) reviewed any time soon? Or is this repo going to be deprecated?

@github-actions
Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions

@loregr
Copy link
Author

loregr commented Apr 11, 2023

Up

@github-actions
Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions

@loregr
Copy link
Author

loregr commented Jun 12, 2023

Up

@jhionan
Copy link

jhionan commented Jul 14, 2023

Now it have conflicts

@nuunoo1977
Copy link

Up, i also need this fixed

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions

@yarn-rp
Copy link

yarn-rp commented Jun 4, 2024

Up

Copy link

github-actions bot commented Jul 5, 2024

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants