-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate equality operator and hashCode functions for route args #1338
base: master
Are you sure you want to change the base?
Conversation
@Milad-Akarie mate, just wondering if there's any plan to have this (and the other PRs) reviewed any time soon? Or is this repo going to be deprecated? |
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions |
Up |
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions |
Up |
Now it have conflicts |
Up, i also need this fixed |
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions |
Up |
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions |
Problem
args
are not included in the equality operator and hashCode functions ofPageRouteInfo
, this means that when comparing two routes (in particular in a mocked testing environment), we are not able to differentiate routes with different args.Solution
Generate the equality operator and hashCode functions for each
RouteArg
, and ensure thatargs
are part of thePageRouteInfo
equality checks. The proposed implementation follows the same approach of freezed package when comparing objects or collection of objects.