Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issues 24, issues 25 #26

Merged
merged 3 commits into from
May 5, 2022
Merged

fix issues 24, issues 25 #26

merged 3 commits into from
May 5, 2022

Conversation

gaodeng
Copy link
Contributor

@gaodeng gaodeng commented Mar 13, 2022

fix #25
fix #24

@gaodeng gaodeng changed the title fix https://github.com/Mikescops/vue-virtual-grid/issues/24 https://github.com/Mikescops/vue-virtual-grid/issues/24 fix issues 24, issues 25 Mar 13, 2022
Mikescops
Mikescops requested changes Mar 14, 2022
View reviewed changes
Copy link
Owner

@Mikescops Mikescops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
Thanks for submitting this idea, I never thought about this use case.
I requested a few changes and information. Among them, I'd like this library to be dependences free 😃

src/VirtualGrid.vue Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/VirtualGrid.vue Outdated Show resolved Hide resolved
@Mikescops
Copy link
Owner

I have to try your changes, but sounds great!

@Mikescops Mikescops merged commit 024836d into Mikescops:main May 5, 2022
@Mikescops
Copy link
Owner

Thanks for your contribution, the new version is released.

@Mikescops Mikescops added the enhancement New feature or request label May 5, 2022
@starypatyk starypatyk mentioned this pull request Mar 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mikescops Mikescops Mikescops requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@gaodeng @Mikescops