Docker debug (#2)

* Tutorial dockerfiles (moveit#463) Build and push docker images for tutorials * fixed clang complaints * removed dockerhub pushes * successfully ran htmlproofer * removed chomp tutorial commits * removed accidental commits * Update CMakeLists.txt * renamed mtc tutorial cpp file * updated cmakelists * updated cmakelists * removed vscode * refactored docker * skipping base image * added conditions on building base image * added conditions on building base image * added conditions on building base image * ran pre commit * Update .docker/Dockerfile Co-authored-by: Robert Haschke <[email protected]> * Update .docker/Dockerfile Co-authored-by: Robert Haschke <[email protected]> * resolved comments * updated location to check for changes * test change to dockerfile * test change to dockerfile * test change to dockerfile * updated scripts to run only when dockerfile changes * fixed syntax * got it building * building dockerfiles of tutorials * added pick container * pushing to new pc * changed to multi-stage * updated dockerfile * rebased * continued rebasing * continued rebasing * continued rebasing * continued rebasing * continued rebasing * merged online edit * continued rebasing * pre commit * modified dockerfile * added ccache to path * merging * merging * successfully ran htmlproofer * removed chomp tutorial commits * removed accidental commits * Update CMakeLists.txt * renamed mtc tutorial cpp file * updated cmakelists * updated cmakelists * removed vscode * merging * merging * ran pre commit * Update .docker/Dockerfile Co-authored-by: Robert Haschke <[email protected]> * Update .docker/Dockerfile Co-authored-by: Robert Haschke <[email protected]> * resolved comments * test change to dockerfile * test change to dockerfile * test change to dockerfile * merging * changed dockerfile * changed dockerfile * changed dockerfile * changed dockerfile * changed dockerfile Co-authored-by: Robert Haschke <[email protected]>
MikeWrock · Jul 15, 2022 · 273c9ed · 273c9ed
1 parent 4f1424f
commit 273c9ed
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 2 deletions.
diff --git a/.docker/Dockerfile b/.docker/Dockerfile
@@ -8,6 +8,7 @@ ARG BASE_BRANCH=
 
 ######################### Base Tutorial Image  #################################################
 
+
 FROM ros:${ROS_DISTRO}-ros-base as base_image
 ENV ROS_UNDERLAY /root/ws_moveit/
 WORKDIR $ROS_UNDERLAY

diff --git a/.github/workflows/docker-base.yml b/.github/workflows/docker-base.yml
@@ -35,7 +35,6 @@ jobs:
         if: steps.changed-files.outputs.any_changed == 'true'
         uses: docker/setup-buildx-action@v2
       - name: Login to Github Container Registry
-        if: steps.changed-files.outputs.any_changed == 'true'
         uses: docker/login-action@v2
         with:
           registry: ghcr.io

diff --git a/.github/workflows/docker-images.yml b/.github/workflows/docker-images.yml
@@ -27,7 +27,6 @@ jobs:
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v2
       - name: Login to Github Container Registry
-        if: env.PUSH == 'true'
         uses: docker/login-action@v2
         with:
           registry: ghcr.io