Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GD-139: Do code cleanup to remove errors and warnings #141

Merged
merged 3 commits into from
Mar 9, 2023
Merged

Conversation

MikeSchulze
Copy link
Owner

@MikeSchulze MikeSchulze commented Mar 8, 2023

Why

By default addons are excluded from code validation, after inclusion the plugin displays over 1800 warnings and some errors
image

What

  • fix the errors
  • reduce the warnings
  • update inline documentation
  • apply formatting rules

Open issues

-Only 23 warnings left, covered by the listed Godot issues
image

  • invalid warnings about enum 74593
    • INT_AS_ENUM_WITHOUT_CAST
    • INT_AS_ENUM_WITHOUT_MATCH
  • disable warnings not work 56592
    • shadowed_global_identifier

By default addons are excluded from code validation, after inclusion the plugin displays over 1800 warnings and some errors

- Fix the errors
- Contain the warnings
@MikeSchulze MikeSchulze marked this pull request as ready for review March 9, 2023 19:35
@MikeSchulze MikeSchulze merged commit 5f7bcbf into master Mar 9, 2023
@MikeSchulze MikeSchulze deleted the GD-139 branch March 9, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GD-139: Enable addon script validation results in a lot of compile errors and warnings
1 participant