Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mechanisms in uppercase are failing #49

Closed
thirsch opened this issue Apr 20, 2023 · 0 comments
Closed

Mechanisms in uppercase are failing #49

thirsch opened this issue Apr 20, 2023 · 0 comments

Comments

@thirsch
Copy link
Contributor

thirsch commented Apr 20, 2023

As of 4.6.1 of RFC 7208, mechanisms and modifiers are case-insensitive, but the lib is throwing an exception in case the mechanism is written as Ip4, iP4 or IP4 (just as a few examples). The dns result should be converted to lowercase to handle such cases.
@thirsch thirsch changed the title Mechanisms in uppercase are failing but seem to be fine in other tools Mechanisms in uppercase are failing Apr 20, 2023
thirsch added a commit to it-solutions-hirsch/PHP-SPF-Check that referenced this issue Apr 27, 2023
@thirsch
Fixes Mika56#49: Converts the matched term to lower case before detec…
9bdb659 
…ting the used mechanism.
@Mika56 Mika56 closed this as completed in 7a03f0e Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thirsch