-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use correct raspi-config command for bookworm #2450
Conversation
s-martin
commented
Nov 3, 2024
•
edited
Loading
edited
- Fixes RDM6300 configuration bug #2444 - original problem see 'raspi-config nonint do_serial' ignores nonint raspberrypi/bookworm-feedback#114 (comment)
- add function to check bookworm
@Darkcast you could test this fix, if you want |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Semantically, this is a great approach. Thanks for adding this function.
To be consistent, I wonder if we want to update the below function as well (in 02_helpers.sh
). It would even reduce the code. Also, there is a condition that would never be reached.
RPi-Jukebox-RFID/installation/includes/02_helpers.sh
Lines 91 to 108 in 027ec29
_get_boot_file_path() { | |
local filename="$1" | |
if [ "$(is_raspbian)" = true ]; then | |
local debian_version_number=$(get_debian_version_number) | |
# Bullseye and lower | |
if [ "$debian_version_number" -le 11 ]; then | |
echo "/boot/${filename}" | |
# Bookworm and higher | |
elif [ "$debian_version_number" -ge 12 ]; then | |
echo "/boot/firmware/${filename}" | |
else | |
echo "unknown" | |
fi | |
else | |
echo "unknown" | |
fi | |
} |
To be changed to this
_get_boot_file_path() {
local filename="$1"
if [ "$(is_raspbian)" = true ]; then
if [ "$(is_bookworm_or_higher)" = true ]; then
echo "/boot/firmware/${filename}"
else
echo "/boot/${filename}"
fi
else
echo "unknown"
fi
}
Merged future3/develop and applied changes. restored previous functions for debian checks. Example:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼