-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Build libzmq locally to work on all host types #2307
fix: Build libzmq locally to work on all host types #2307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have only tested this on Mac so far. If others could help trying this out on their machine, that would be great.
Tested this on Windows (WSL, x86_64) successfully. |
Co-authored-by: notapirate <[email protected]>
@notapirate could you add a comment, with which platform/configuration it works for you? |
Sure, I tested this on Linux (Arch Linux, x86_64) successfully. |
On Windows 11 building the images works now, also running :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pabera you may want to double-check changes in docker.md, I think the item numbering got messed up :)
Not necessary, „markdown magic“ renders the numbering correctly. |
@pabera |
After #2312 is merged the error in the CodeQL action should be gone. |
This PR addresses and aims to resolve the building issues associated with
libzmq
across all platforms.Previously, the strategy of utilizing pre-built libzmq binaries within Docker environments was intended to streamline development processes. However, this approach did not achieve the desired outcome of creating a seamless and frustration-free development experience.
We are shifting back to locally building
libzmq
. This process is now consolidated within a dedicated Dockerfile, ensuring that the build is required only once. Once the build is completed, it becomes readily accessible and shareable across all Docker environments, significantly improving the development workflow.Introduces changes
libzmq
build into local Docker build. Artefacts are shared between Dockerfiles[name].Dockerfile
toDockerfile.[name]
(easier to find in file tree)Should solve:
Relates to:
Test