Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PowerToys] Run: Update calculator section and add service plugin #3860

Merged
merged 7 commits into from
Jun 13, 2022
Merged

[PowerToys] Run: Update calculator section and add service plugin #3860

merged 7 commits into from
Jun 13, 2022

Conversation

htcfreek
Copy link
Contributor

@htcfreek htcfreek commented May 29, 2022 •
edited
Loading

Update docs for new behavior introduced in microsoft/PowerToys/pull/18159.

image

Add information for service plugin about the new search features introduced in microsoft/PowerToys/pull/17985.

  • Update plugin keyword table examples.
  • Add section for services plugin.

image

Please don't merge before an approval of @crutkas or @jaimecbernardo and the release of PT v0.59.0 in June 2022!!

@PRMerger17
Copy link
Contributor

@htcfreek : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger16 PRMerger16 requested a review from mattwojo May 29, 2022 12:28
@PRMerger15
Copy link
Contributor

@htcfreek : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@htcfreek htcfreek mentioned this pull request May 29, 2022
Merged
26 tasks
@jborsecnik
Copy link
Contributor

@mattwojo,

Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge. Thanks.

#label:"aq-pr-triaged"

@PRMerger5 PRMerger5 added the aq-pr-triaged tracking label for the PR review team label May 30, 2022
@htcfreek
Copy link
Contributor Author

htcfreek commented May 30, 2022 •
edited
Loading

@mattwojo
The feature changes coming wiith th release v0.60.0 at the end of June. Please hold this PR until the end of June.

@htcfreek htcfreek changed the title [PowerToys] Run: Update calculator docs [PowerToys] Run: Update calculator and add service plugin Jun 3, 2022
@PRMerger10
Copy link
Contributor

@htcfreek : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger3
Copy link
Contributor

@htcfreek : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@htcfreek
Copy link
Contributor Author

htcfreek commented Jun 3, 2022

@crutkas , @jaimecbernardo
I have updated the PR and added the changes for service plugin too.

@htcfreek htcfreek changed the title [PowerToys] Run: Update calculator and add service plugin [PowerToys] Run: Update calculator section and add service plugin Jun 3, 2022
jaimecbernardo
jaimecbernardo approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution!

@Court72
Copy link
Contributor

Court72 commented Jun 6, 2022

@mattwojo

Could you review this proposed update to your article and enter #sign-off in a comment if it's approved for merge?

Thanks!

@Court72
Copy link
Contributor

Court72 commented Jun 6, 2022

#assign:@MicrosoftDocs/public-repo-pr-review-team

@PRMerger14
Copy link
Contributor

The following users don't have valid GitHub IDs, or are not collaborators on this repo: microsoftdocs/public-repo-pr-review-team

@htcfreek
Copy link
Contributor Author

htcfreek commented Jun 8, 2022

We can merge this

@htcfreek
Copy link
Contributor Author

@mattwojo
Can you please review this?

@PRMerger18
Copy link
Contributor

@mattwojo : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@mattwojo
Copy link
Contributor

Made some minor wording adjustments. Looks good to me. Merging.

@mattwojo mattwojo merged commit f55bdfe into MicrosoftDocs:docs Jun 13, 2022
@htcfreek
Copy link
Contributor Author

Made some minor wording adjustments. Looks good to me. Merging.

Thank you. Great adjustments.

@htcfreek htcfreek deleted the PtDocsCalc branch June 13, 2022 21:40
learn-build-service-prod bot added a commit that referenced this pull request Oct 27, 2023
@learn-build-service-prod
Merge pull request #3860 from MicrosoftDocs/main638340424179829925syn…
b99d98b 
…c_temp

For protected branch, push strategy should use PR and merge to target branch method to work around git push error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaimecbernardo jaimecbernardo jaimecbernardo approved these changes

@mattwojo mattwojo Awaiting requested review from mattwojo

Assignees

@mattwojo mattwojo

Labels
aq-pr-triaged tracking label for the PR review team Change sent to author dev-environment/prod do-not-merge powertoys/tech PowerToys docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.