Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation updates #525

Merged
merged 7 commits into from
Oct 30, 2024
Merged

Documentation updates #525

merged 7 commits into from
Oct 30, 2024

Conversation

localden
Copy link
Collaborator

No description provided.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@trwalke
Copy link
Contributor

trwalke commented Oct 29, 2024

So many issues require logs and most customers do not enable them by default. They often have no idea MSAL even has logging, Was thinking it is a good idea to introduce the importance of logging earlier in the migration process to MSAL, like these pages for example. Just a thought.

trwalke
trwalke previously approved these changes Oct 29, 2024

This comment was marked as outdated.

@localden
Copy link
Collaborator Author

@trwalke great idea, let me add a note here for logging.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Copy link
Contributor

@trwalke trwalke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@localden localden merged commit 7d7846b into main Oct 30, 2024
3 checks passed
@localden localden deleted the doc-updates branch October 30, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants