-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tutorial-managed-identities-key-vault.md #97378
Update tutorial-managed-identities-key-vault.md #97378
Conversation
@moarychan : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
||
:::image type="content" source="media/tutorial-managed-identities-key-vault/app-user-managed-identity-key-vault.png" alt-text="Screenshot of Azure portal showing the Managed Identity Properties screen with 'Principle I D' and 'Client I D' highlighted." lightbox="media/tutorial-managed-identities-key-vault/app-user-managed-identity-key-vault.png"::: | ||
:::image type="content" source="media/tutorial-managed-identities-key-vault/app-user-managed-identity-key-vault.png" alt-text="Screenshot of Azure portal showing the Managed Identity Properties screen with 'Resource I D', 'Principle I D' and 'Client I D' highlighted." lightbox="media/tutorial-managed-identities-key-vault/app-user-managed-identity-key-vault.png"::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use ID
instead of I D
? I mean delete the space between I
and D
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also noticed this usage, let me remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did that at one point for alt-text values so that screen readers will read the letters separately. However, the guidance now states that this is unnecessary for capitalized acronyms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KarlErickson Thanks for sharing the information.
However, the guidance now states that this is unnecessary for capitalized acronyms.
Could you please share the link to the guidance
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moarychan : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
#label:"aq-pr-triaged" |
@moarychan @saragluna @chenrujun FYI internal contributors should submit PRs against the private repo at azure-docs-pr. If you click the "edit" button on a published article, it will take you to the public repo, but you can simply update the URL to add the "-pr" at the end of the repo name. That said, this PR looks okay to merge, after a minor edit I made is committed. #sign-off PR Merger - can you commit the small copy edit on line 96 before you merge? Thanks! |
Co-authored-by: Karl Erickson <[email protected]>
@Jak-MS : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
@moarychan @saragluna @chenrujun @KarlErickson - the new screenshot contains private information and can't be merged as is. Can you remove email address in the screenshot (replace with a fictitious one or mask it with the background color)? thanks, |
@moarychan : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Based on the basis of this PR #97305, this PR will update the screenshot and make minor improvements.