Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorial-managed-identities-key-vault.md #97378

Merged

Conversation

moarychan
Copy link
Contributor

Based on the basis of this PR #97305, this PR will update the screenshot and make minor improvements.

@prmerger-automator
Copy link
Contributor

@moarychan : Thanks for your contribution! The author(s) have been notified to review your proposed change.


:::image type="content" source="media/tutorial-managed-identities-key-vault/app-user-managed-identity-key-vault.png" alt-text="Screenshot of Azure portal showing the Managed Identity Properties screen with 'Principle I D' and 'Client I D' highlighted." lightbox="media/tutorial-managed-identities-key-vault/app-user-managed-identity-key-vault.png":::
:::image type="content" source="media/tutorial-managed-identities-key-vault/app-user-managed-identity-key-vault.png" alt-text="Screenshot of Azure portal showing the Managed Identity Properties screen with 'Resource I D', 'Principle I D' and 'Client I D' highlighted." lightbox="media/tutorial-managed-identities-key-vault/app-user-managed-identity-key-vault.png":::

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use ID instead of I D? I mean delete the space between I and D.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also noticed this usage, let me remove it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did that at one point for alt-text values so that screen readers will read the letters separately. However, the guidance now states that this is unnecessary for capitalized acronyms.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KarlErickson Thanks for sharing the information.

However, the guidance now states that this is unnecessary for capitalized acronyms.

Could you please share the link to the guidance?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prmerger-automator
Copy link
Contributor

@moarychan : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Jak-MS
Copy link
Contributor

Jak-MS commented Aug 22, 2022

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Aug 22, 2022
@KarlErickson
Copy link
Contributor

@moarychan @saragluna @chenrujun FYI internal contributors should submit PRs against the private repo at azure-docs-pr. If you click the "edit" button on a published article, it will take you to the public repo, but you can simply update the URL to add the "-pr" at the end of the repo name.

That said, this PR looks okay to merge, after a minor edit I made is committed.

#sign-off

PR Merger - can you commit the small copy edit on line 96 before you merge? Thanks!

@prmerger-automator
Copy link
Contributor

@Jak-MS : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Jak-MS
Copy link
Contributor

Jak-MS commented Aug 22, 2022

@moarychan @saragluna @chenrujun @KarlErickson - the new screenshot contains private information and can't be merged as is. Can you remove email address in the screenshot (replace with a fictitious one or mask it with the background color)?

thanks,
#hold-off

@prmerger-automator
Copy link
Contributor

@moarychan : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Jak-MS Jak-MS merged commit 81f68fb into MicrosoftDocs:main Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants