-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement of nvidia-device-plugin-daemonset in gpu-cluster.md #138
base: main
Are you sure you want to change the base?
Conversation
@JoeyC-Dev : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit 07ab281: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
@schaffererin This PR hasn’t had any updates for a while. If it's ready for review, could you sign off? Or should it be closed? #label:"aq-pr-triaged","aq-followed-up" |
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
This PR is critical for users who aren't expert on Kubernetes as they don't know why their driver cannot be installed. @MicrosoftDocs/public-repo-pr-review-team |
I sent an email to the content owner today. |
Proposed change: Improve the Nvidia device plugin deamonset for better deployment.
Supporting point:
tolerations
to relativetaint
.nodeSelector
.v0.17.0
. Update image version relatively: https://github.com/NVIDIA/k8s-device-plugin/releasesgpu-operator
, but there is no actual use in the daemonset. Consider this is a manual set-up, I kept it as in namespacegpu-operator
and change the yaml relatively.azure-aks-docs/articles/aks/gpu-cluster.md
Lines 128 to 132 in 130a484
Having checked, the propsed yaml is working, and it will deploy the ds on Nvidia GPU node.


Successful deployment: