Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong statement about system nodepool in create-node-pools.md #108

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JoeyC-Dev
Copy link
Contributor

Proposed change: Fixing wrong concept of "system nodepool = control plane".

Supporting points:

  1. Control Plane nodes or Pods in Control Plane is not visible to users. Reducing nodes in system nodepool will cause impact to control plane is false statement. Adding control plane nodes is also not an option for users.
  2. Since it is never related to control plane, "lose control plane resources" is also false statement.

Copy link
Contributor

@JoeyC-Dev : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link

Learn Build status updates of commit 5ada381:

✅ Validation status: passed

File Status Preview URL Details
articles/aks/create-node-pools.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@ttorble
Copy link
Contributor

ttorble commented Dec 6, 2024

@schaffererin

Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants