-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docfx.json #12
Conversation
✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
@Rick-Anderson What is this change for? |
@mairaw we need this change for the APEX meta-data initiative - right? |
Yes @Rick-Anderson but I'll leave some comments |
IIS-Administration/docfx.json
Outdated
"breadcrumb_path": "/iis/breadcrumb/toc.json", | ||
"_navPath": "/foo", | ||
"_navRel": "/foo", | ||
"searchScope": "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not add a search scope?
IIS-Administration/docfx.json
Outdated
"fileMetadata": {}, | ||
"globalMetadata": { | ||
"breadcrumb_path": "/iis/breadcrumb/toc.json", | ||
"_navPath": "/foo", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not familiar with these too _navPath and _navRel
"_navRel": "/foo", | ||
"searchScope": "" | ||
}, | ||
"fileMetadata": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of adding filemetadata, add these in the globalmetadata bucket
@@ -30,7 +30,20 @@ | |||
"overwrite": [], | |||
"externalReference": [], | |||
"globalMetadata": {}, | |||
"fileMetadata": {}, | |||
"globalMetadata": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you also need author and ms.author values and I'm seeing that all content is missing required metadata like title, description and ms.date.
IIS-Administration/docfx.json
Outdated
@@ -30,7 +30,20 @@ | |||
"overwrite": [], | |||
"externalReference": [], | |||
"globalMetadata": {}, | |||
"fileMetadata": {}, | |||
"globalMetadata": { | |||
"breadcrumb_path": "/iis/breadcrumb/toc.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do they have this configured?
@shirhatti content published on docs.microsoft.com has some special metadata requirements for BI tracking purposes. We're running reports on all content published on docs now to find content that is missing or using wrong values for those and this repo was one that was flagged. You can find more info about metadata at https://review.docs.microsoft.com/en-us/help/contribute/metadata-attributes?branch=master |
IIS-Administration/docfx.json
Outdated
"**/**.md": "iis-admin" | ||
}, | ||
"ms.topic": { | ||
"**/**.md": "conceptual" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wondering if the content under the API path should be set as reference
@mairaw @Rick-Anderson Is this going to be merged? |
@Rick-Anderson , Maira is out. Can you, Scott or Tim get this?
|
✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
This can be closed. It's replaced by #18. |
No description provided.