Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docfx.json #12

Closed
wants to merge 4 commits into from
Closed

Update docfx.json #12

wants to merge 4 commits into from

Conversation

Rick-Anderson
Copy link
Contributor

No description provided.

@shirhatti
Copy link
Contributor

✅ Validation status: passed

File Status Preview URL Details
IIS-Administration/docfx.json ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@shirhatti
Copy link
Contributor

shirhatti commented Oct 5, 2018

@Rick-Anderson What is this change for?

@Rick-Anderson
Copy link
Contributor Author

@mairaw we need this change for the APEX meta-data initiative - right?

@mairaw
Copy link
Contributor

mairaw commented Oct 11, 2018

Yes @Rick-Anderson but I'll leave some comments

"breadcrumb_path": "/iis/breadcrumb/toc.json",
"_navPath": "/foo",
"_navRel": "/foo",
"searchScope": ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not add a search scope?

"fileMetadata": {},
"globalMetadata": {
"breadcrumb_path": "/iis/breadcrumb/toc.json",
"_navPath": "/foo",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not familiar with these too _navPath and _navRel

"_navRel": "/foo",
"searchScope": ""
},
"fileMetadata": {
Copy link
Contributor

@mairaw mairaw Oct 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of adding filemetadata, add these in the globalmetadata bucket

@@ -30,7 +30,20 @@
"overwrite": [],
"externalReference": [],
"globalMetadata": {},
"fileMetadata": {},
"globalMetadata": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you also need author and ms.author values and I'm seeing that all content is missing required metadata like title, description and ms.date.

@@ -30,7 +30,20 @@
"overwrite": [],
"externalReference": [],
"globalMetadata": {},
"fileMetadata": {},
"globalMetadata": {
"breadcrumb_path": "/iis/breadcrumb/toc.json",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do they have this configured?

@mairaw
Copy link
Contributor

mairaw commented Oct 11, 2018

@shirhatti content published on docs.microsoft.com has some special metadata requirements for BI tracking purposes. We're running reports on all content published on docs now to find content that is missing or using wrong values for those and this repo was one that was flagged. You can find more info about metadata at https://review.docs.microsoft.com/en-us/help/contribute/metadata-attributes?branch=master

"**/**.md": "iis-admin"
},
"ms.topic": {
"**/**.md": "conceptual"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering if the content under the API path should be set as reference

@shirhatti
Copy link
Contributor

@mairaw @Rick-Anderson Is this going to be merged?

@wadepickett
Copy link

wadepickett commented Oct 31, 2018 via email

@rick rick mentioned this pull request Oct 31, 2018
@shirhatti
Copy link
Contributor

✅ Validation status: passed

File Status Preview URL Details
IIS-Administration/docfx.json ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@MicrosoftDocs MicrosoftDocs deleted a comment from rick Oct 31, 2018
@MicrosoftDocs MicrosoftDocs deleted a comment from shirhatti Oct 31, 2018
@shirhatti
Copy link
Contributor

✅ Validation status: passed

File Status Preview URL Details
IIS-Administration/docfx.json ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@mairaw
Copy link
Contributor

mairaw commented Feb 22, 2019

This can be closed. It's replaced by #18.

@shirhatti shirhatti closed this Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants