Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update renderer status page to reflect input validation #321

Merged
merged 5 commits into from
Aug 4, 2020

Conversation

RebeccaAnne
Copy link
Contributor

@RebeccaAnne RebeccaAnne commented Aug 4, 2020

Updated the "Full Input Support" row to reflect that .NET HTML doesn't have label/validation support. Also updated the UWP custom action rendering checkbox to reflect that that support now exists.

Microsoft Reviewers: Open in CodeFlow

@opbld31
Copy link

opbld31 commented Aug 4, 2020

Docs Build status updates of commit 091dce6:

⚠️ Validation status: warnings

File Status Preview URL Details
AdaptiveCards/rendering-cards/renderer-status.md ⚠️Warning Details

AdaptiveCards/rendering-cards/renderer-status.md

  • Line 36, Column 2: [Warning-bookmark-not-found] Cannot find bookmark '#markdown' in 'authoring-cards/text-features.md'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld32
Copy link

opbld32 commented Aug 4, 2020

Docs Build status updates of commit 7c3e051:

⚠️ Validation status: warnings

File Status Preview URL Details
AdaptiveCards/rendering-cards/renderer-status.md ⚠️Warning Details

AdaptiveCards/rendering-cards/renderer-status.md

  • Line 36, Column 2: [Warning-bookmark-not-found] Cannot find bookmark '#Markdown-(Commonmark-subset)' in 'authoring-cards/text-features.md', did you mean '#markdown-commonmark-subset'?

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld33
Copy link

opbld33 commented Aug 4, 2020

Docs Build status updates of commit 48f28d4:

⚠️ Validation status: warnings

File Status Preview URL Details
AdaptiveCards/rendering-cards/renderer-status.md ⚠️Warning Details

AdaptiveCards/rendering-cards/renderer-status.md

  • Line 36, Column 2: [Warning-bookmark-not-found] Cannot find bookmark '#Markdown-(Commonmark-subset)' in 'authoring-cards/text-features.md', did you mean '#markdown-commonmark-subset'?

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld33
Copy link

opbld33 commented Aug 4, 2020

Docs Build status updates of commit 12ef777:

⚠️ Validation status: warnings

File Status Preview URL Details
AdaptiveCards/rendering-cards/renderer-status.md ⚠️Warning Details

AdaptiveCards/rendering-cards/renderer-status.md

  • Line 36, Column 2: [Warning-bookmark-not-found] Cannot find bookmark '#Markdown-Commonmark-subset' in 'authoring-cards/text-features.md', did you mean '#markdown-commonmark-subset'?

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@shalinijoshi19
Copy link
Contributor

Docs Build status updates of commit 091dce6:

⚠️ Validation status: warnings

File Status Preview URL Details
AdaptiveCards/rendering-cards/renderer-status.md ⚠️Warning Details

AdaptiveCards/rendering-cards/renderer-status.md

  • Line 36, Column 2: [Warning-bookmark-not-found] Cannot find bookmark '#markdown' in 'authoring-cards/text-features.md'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

We should fix this warning (i think we can leave off the suggestions for now)..

shalinijoshi19
shalinijoshi19 previously approved these changes Aug 4, 2020
Copy link
Contributor

@shalinijoshi19 shalinijoshi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@@ -33,8 +33,8 @@ The tables below show the current status of each renderer, based on their public
|--- | --- | --- | --- | --- | --- | --- |
|Spacing and Separator | ✅ | ✅ | ✅ | ✅ | ✅ |
|[TextBlock DATE/TIME formatting](../authoring-cards/text-features.md#datetime-formatting-and-localization) | ✅ | ✅ | ✅ | ✅ | ✅ |
|[TextBlock Markdown support](../authoring-cards/text-features.md#markdown) | ✅* | ✅ | ✅ | ✅ | ✅ |
|Full Input support | ✅ | ✅ | ✅ | ✅ | ✅ |
|[TextBlock Markdown support](../authoring-cards/text-features.md#Markdown-Commonmark-subset) | ✅* | ✅ | ✅ | ✅ | ✅ |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • [](start = 97, length = 1)

This might have been recently updated with Matt's changes perhaps - Pls update link to "#markdown-commonmark-subset"

@shalinijoshi19 shalinijoshi19 dismissed their stale review August 4, 2020 00:44

revoking review

@opbld31
Copy link

opbld31 commented Aug 4, 2020

Docs Build status updates of commit 95ad6c7:

✅ Validation status: passed

File Status Preview URL Details
AdaptiveCards/rendering-cards/renderer-status.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@RebeccaAnne RebeccaAnne merged commit f345089 into master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants