Skip to content
This repository has been archived by the owner on Oct 2, 2021. It is now read-only.

Support https protocol using any certificate #151

Merged
merged 1 commit into from
Jan 10, 2017
Merged

Support https protocol using any certificate #151

merged 1 commit into from
Jan 10, 2017

Conversation

kanongil
Copy link
Contributor

@kanongil kanongil commented Jan 9, 2017

This fixes #65 by adding https support to getURL().

Note that I always set the rejectUnauthorized = false option, which disables the certificate validation checks. This is done to enable fetching from self-signed certificates, which are often used for local https development setups. This should be safe as long as it the method is only used for local resources.

@msftclas
Copy link

msftclas commented Jan 9, 2017

Hi @kanongil, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@roblourens
Copy link
Member

Awesome, thanks.

@roblourens roblourens merged commit 73b1a32 into microsoft:master Jan 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not work if the url is under https
3 participants