Skip to content
This repository has been archived by the owner on Oct 2, 2021. It is now read-only.

Does not work if the url is under https #65

Closed
ligaz opened this issue Jul 13, 2016 · 5 comments · Fixed by #151
Closed

Does not work if the url is under https #65

ligaz opened this issue Jul 13, 2016 · 5 comments · Fixed by #151
Labels

Comments

@ligaz
Copy link

ligaz commented Jul 13, 2016

The code is not working correctly if the url protocol is https and there are source maps because it cannot download the source map file.

It looks like the problem is the usage of the http module in utils. getURL. A better alternative is the fetch API available via node-fetch module.

@roblourens
Copy link
Member

Thanks for the report, I didn't realize that Node has separate http and https modules.

@roblourens roblourens added the bug label Jul 13, 2016
@auchenberg
Copy link
Contributor

@jhicken
Copy link

jhicken commented Jan 24, 2017

@roblourens So not to be a pain in the butt.... Whats the time frame on this being released.

Alt Text

I'm really excited about it.

@roblourens
Copy link
Member

Sorry for the delay, I've been working on vscode 1.9. I'll update it this week though :)

@jhicken
Copy link

jhicken commented Jan 25, 2017

Buahaha. No need to apologize. I'm just grateful for your hard work.
Thanks for the update brother man.

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants