Update tslib to support new __spreadArray helper #133

rbuckton · 2020-11-13T01:41:56Z

This applies the same change from microsoft/TypeScript#41523. This also deprecates __spread and __spreadArrays, as they have been subsumed by __spreadArray. If we want to remove __spread and __spreadArrays, that would require a major version bump.

rbuckton · 2020-11-13T02:02:33Z

@orta, CI for 14.x failed but I'm not sure why: https://github.com/microsoft/tslib/pull/133/checks?check_run_id=1393759257#step:4:35

ExE-Boss · 2020-11-13T20:26:48Z

tslib.d.ts

 export declare function __spreadArrays(...args: any[][]): any[];
+export declare function __spreadArray(to: any[], from: any[]): any[];


This is more correct:

Suggested change

export declare function __spreadArray(to: any[], from: any[]): any[];

export declare function __spreadArray<T, U>(to: T[], from: ReadonlyArray<U>): Array<T | U>;

Although this would be even more correct, it depends on TypeScript 4.0:

export declare function __spreadArray<T extends any[], U extends readonly any[]>(to: T, from: U): [...T, ...U];

The types here are fairly simplistic. If we were going to add generics here we would want to add them to other functions as well, but that's out of scope for now.

ExE-Boss · 2020-11-15T23:40:36Z

Do note that /modules/index.js also needs updating.

orta · 2020-11-18T16:12:24Z

Thanks! Got a local repro for the fail

orta · 2020-11-18T16:30:35Z

Great catch on the modules/index.js - ideally that would have just failed the build, will look at that now

orta

Changes look good to me, and I've validated the CI works as expected.

I'll leave you to decide whether the generic change above is worth it here.

rbuckton · 2020-12-18T01:43:26Z

@DanielRosenwasser this will probably need to be published before we merge microsoft/TypeScript#41523 so anyone using our nightlies can get a working copy of tslib.

Finesse · 2021-02-11T00:39:54Z

Which version of TypeScript will start using __spreadArray instead of __spread and __spreadArrays?

ExE-Boss · 2021-02-11T09:51:27Z

@Finesse TypeScript is using __spreadArray as of TypeScript 4.2 beta (microsoft/TypeScript@44ec8dd).

- Since Typescript 4.2 some Helpers to transpile to 4.2 are deprecated/removed. This includes __spread and __spreadArrays microsoft/TypeScript#41523. - We heavily use the spread syntax in Dark Reader and thus need those helper functions. - Due the upgrade of 4.2, tslib was outdated and didn't had the new helper function `__spreadArray`. - After good hours of skimming trough the compiler and using the wrong commands to update tslib(default to 1.x). manually updating it to 2.1 which includes this new functions microsoft/tslib#133 https://github.com/microsoft/tslib/releases/tag/2.1.0 the API can be properly compiled again. - Resolves #My personal issues with the API.

- Since Typescript 4.2 some Helpers to transpile to 4.2 are deprecated/removed. This includes __spread and __spreadArrays microsoft/TypeScript#41523. - We heavily use the spread syntax in Dark Reader and thus need those helper functions. - Due the upgrade of 4.2, tslib was outdated and didn't had the new helper function `__spreadArray`. - After good hours of skimming trough the compiler and using the wrong commands to update tslib(default to 1.x). manually updating it to 2.1 which includes this new functions microsoft/tslib#133 https://github.com/microsoft/tslib/releases/tag/2.1.0 the API can be properly compiled again. - Resolves #My personal issues with the API. Note to myself: Now their are 2 versions installed `2.1.10` and `1.14.1` properly configuration setups should default to 2.1.10. But for sakes if I get into problems with this I hope I remember this note and don't waste some hours. Why `1.14.1`, I don't know. `npm --save-dev -E tslib` defaults to 1.14.1. It seems like an NPM bug `yarn add --dev -E tslib` gives the correct 2.1.10. Damn dependency hell =).

The version + features of typescript used to compile this lib means that tslib needs to be at version 2.0.0 minimum. Because `antvis/algorithm` doesn't specify an explicit version, it is not guaranteed that developers receive the necessary version. This causes the following error at import time: ``` ./node_modules/@antv/algorithm/es/gaddi.js Attempted import error: '__spreadArray' is not exported from 'tslib'. ``` You can see here all the other projects updating their tslib dependencies similarly in the references to this PR: microsoft/tslib#133 This relates to antvis/G6#2702 and antvis/G6#2713 it is likely necessary, but may not be sufficient, to fix those reported issues. There could be other `antvis` packages with the same issue.

This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [tslib](https://www.typescriptlang.org/) ([source](https://togithub.com/Microsoft/tslib)) | [`2.6.2` -> `2.6.3`](https://renovatebot.com/diffs/npm/tslib/1.14.1/2.6.3) | [![age](https://developer.mend.io/api/mc/badges/age/npm/tslib/2.6.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/tslib/2.6.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/tslib/1.14.1/2.6.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/tslib/1.14.1/2.6.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Microsoft/tslib (tslib)</summary> ### [`v2.6.3`](https://togithub.com/microsoft/tslib/releases/tag/v2.6.3) [Compare Source](https://togithub.com/Microsoft/tslib/compare/v2.6.2...v2.6.3) #### What's Changed - 'await using' normative changes by [@rbuckton](https://togithub.com/rbuckton) in [https://github.com/microsoft/tslib/pull/258](https://togithub.com/microsoft/tslib/pull/258) **Full Changelog**: microsoft/tslib@v2.6.2...v2.6.3 ### [`v2.6.2`](https://togithub.com/microsoft/tslib/releases/tag/v2.6.2): tslib 2.6.2 [Compare Source](https://togithub.com/Microsoft/tslib/compare/v2.6.1...v2.6.2) #### What's Changed - Fix path to `exports["module"]["types"]` by [@andrewbranch](https://togithub.com/andrewbranch) in [https://github.com/microsoft/tslib/pull/217](https://togithub.com/microsoft/tslib/pull/217) **Full Changelog**: microsoft/tslib@v2.6.1...v2.6.2 ### [`v2.6.1`](https://togithub.com/microsoft/tslib/releases/tag/v2.6.1): tslib 2.6.1 [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.6.0...v2.6.1) #### What's Changed - Allow functions as values in \__addDisposableResource by [@rbuckton](https://togithub.com/rbuckton) in [https://github.com/microsoft/tslib/pull/215](https://togithub.com/microsoft/tslib/pull/215) - Stop using es6 syntax in the es6 file by [@andrewbranch](https://togithub.com/andrewbranch) in [https://github.com/microsoft/tslib/pull/216](https://togithub.com/microsoft/tslib/pull/216) **Full Changelog**: microsoft/tslib@2.6.0...v2.6.1 ### [`v2.6.0`](https://togithub.com/microsoft/tslib/releases/tag/2.6.0): tslib 2.6.0 [Compare Source](https://togithub.com/Microsoft/tslib/compare/v2.5.3...2.6.0) #### What's Changed - Add helpers for `using` and `await using` by [@rbuckton](https://togithub.com/rbuckton) in [https://github.com/microsoft/tslib/pull/213](https://togithub.com/microsoft/tslib/pull/213) **Full Changelog**: microsoft/tslib@v2.5.3...2.6.0 ### [`v2.5.3`](https://togithub.com/microsoft/tslib/releases/tag/v2.5.3): tslib 2.5.3 [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.5.2...v2.5.3) #### What's Changed - Do not reference tslib.es6.js from package.json exports by [@andrewbranch](https://togithub.com/andrewbranch) in [https://github.com/microsoft/tslib/pull/208](https://togithub.com/microsoft/tslib/pull/208) **Full Changelog**: microsoft/tslib@2.5.2...v2.5.3 ### [`v2.5.2`](https://togithub.com/microsoft/tslib/releases/tag/2.5.2): tslib 2.5.2 [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.5.1...2.5.2) This release [explicitly re-exports helpers](https://togithub.com/microsoft/tslib/pull/204) to work around TypeScript's incomplete symbol resolution for tslib. ### [`v2.5.1`](https://togithub.com/microsoft/tslib/releases/tag/2.5.1): tslib 2.5.1 [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.5.0...2.5.1) This release of tslib provides fixes for two issues. First, [it reverses the order of `init` hooks provided by decorators](https://togithub.com/microsoft/tslib/pull/202) to correctly reflect proposed behavior. Second, it [corrects the `exports` field of tslib's `package.json` and provides accurate declaration files](https://togithub.com/microsoft/tslib/pull/202) so that it may be consumed under the `node16` and `bundler` settings for `moduleResolution.` ### [`v2.5.0`](https://togithub.com/microsoft/tslib/releases/tag/2.5.0): tslib 2.5.0 [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.4.1...2.5.0) #### What's New - Fix asyncDelegator reporting done too early by [@apendua](https://togithub.com/apendua) in [https://github.com/microsoft/tslib/pull/187](https://togithub.com/microsoft/tslib/pull/187) - Add support for TypeScript 5.0's `__esDecorate` and related helpers by [@rbuckton](https://togithub.com/rbuckton) in [https://github.com/microsoft/tslib/pull/193](https://togithub.com/microsoft/tslib/pull/193) **Full Changelog**: microsoft/tslib@2.4.1...2.5.0 ### [`v2.4.1`](https://togithub.com/microsoft/tslib/releases/tag/2.4.1): tslib 2.4.1 [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.4.0...2.4.1) This release contains [fixes for early `return`s and `throw`s invoked on generators](https://togithub.com/microsoft/tslib/pull/186). ### [`v2.4.0`](https://togithub.com/microsoft/tslib/releases/tag/2.4.0): tslib 2.4.0 [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.3.1...2.4.0) This release includes the `__classPrivateFieldIn` helper as well as an update to `__createBinding` to reduce indirection between multiple re-exports. ### [`v2.3.1`](https://togithub.com/microsoft/tslib/releases/tag/2.3.1): tslib 2.3.1 [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.3.0...2.3.1) This release updates the `__spreadArray` helper for TypeScript 4.4 to correctly operate on collections that are not "concat-spreadable" such as the DOM's `NodeList`s and `HTMLCollection`s. ### [`v2.3.0`](https://togithub.com/microsoft/tslib/releases/tag/2.3.0): tslib 2.3.0 [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.2.0...2.3.0) This release updates tslib to use TypeScript 4.4's upcoming `__spreadArray` helper which correctly preserves sparse array inputs (e.g. arrays containing "missing" elements like `[1, 2, , 4]`). This new version of `__spreadArray` is backwards-compatible and is often also faster. See [https://github.com/microsoft/tslib/pull/151](https://togithub.com/microsoft/tslib/pull/151) for more details. ### [`v2.2.0`](https://togithub.com/microsoft/tslib/releases/tag/2.2.0): tslib 2.2.0 [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.1.0...2.2.0) This release supports TypeScript 4.3's new functionality for ECMAScript private methods and accessors, and private static class members. It does so by expanding the scope of `__classPrivateFieldGet` and `__classPrivateFieldSet`. See [https://github.com/microsoft/tslib/pull/146](https://togithub.com/microsoft/tslib/pull/146) for more details. ### [`v2.1.0`](https://togithub.com/microsoft/tslib/releases/tag/2.1.0): tslib 2.1.0 [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.0.3...2.1.0) This release adds a new `__spreadArray` helper which avoids side-effects compared to the now-deprecated `__spreadArrays` and `__spread` helpers. See [https://github.com/microsoft/tslib/pull/133](https://togithub.com/microsoft/tslib/pull/133) for more details. This release also provides a more-specific error message when extending from a type which is not a function and not null. See [https://github.com/microsoft/tslib/pull/138](https://togithub.com/microsoft/tslib/pull/138) for more details. ### [`v2.0.3`](https://togithub.com/microsoft/tslib/releases/tag/2.0.3): Webpack 5 Compatibility - 2.x [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.0.2...2.0.3) Full discussion in the [webpack issue](https://togithub.com/webpack/webpack/issues/11613) ### [`v2.0.2`](https://togithub.com/microsoft/tslib/releases/tag/2.0.2): ES Module Support [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.0.1...2.0.2) This release adds support for using tslib in Node using esmodule imports, further context in [#126](https://togithub.com/Microsoft/tslib/issues/126) and the related issues. ### [`v2.0.1`](https://togithub.com/microsoft/tslib/releases/tag/2.0.1): Minor release for TS 4.0 [Compare Source](https://togithub.com/Microsoft/tslib/compare/2.0.0...2.0.1) 1. Use Object.prototype.hasOwnProperty.call. 2. Skip default when iterating exports in \__importStar. 3. Shorter parameter name in \__exportStar. ### [`v2.0.0`](https://togithub.com/microsoft/tslib/releases/tag/2.0.0): tslib 2.0.0 [Compare Source](https://togithub.com/Microsoft/tslib/compare/v1.14.1...2.0.0) This release changes `__exportStar` and `__importStar` to use `__createBinding` which is incompatible with versions of TypeScript older than 3.9 (i.e. 3.8 and below). </details> --- - [ ] If you want to rebase/retry this PR, check this box  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

rbuckton requested a review from orta November 13, 2020 01:41

ExE-Boss reviewed Nov 13, 2020

View reviewed changes

Update tslib to support new __spreadArray helper

cd43f05

orta force-pushed the fixTS32959 branch from 7460809 to cd43f05 Compare November 18, 2020 16:28

Ensure that the modules exports are validated in tests

be654a5

orta force-pushed the fixTS32959 branch from a39a346 to be654a5 Compare November 18, 2020 16:42

Adds spreadArray to the module exports

2c150df

orta approved these changes Nov 18, 2020

View reviewed changes

rbuckton mentioned this pull request Dec 18, 2020

Fix array spread with sideeffects microsoft/TypeScript#41523

Merged

rbuckton merged commit 88a77b8 into master Dec 18, 2020

rbuckton deleted the fixTS32959 branch December 18, 2020 01:40

cc-prodsec mentioned this pull request Jan 27, 2021

[Snyk] Upgrade tslib from 2.0.3 to 2.1.0 SalesforceCommerceCloud/commerce-sdk#291

Merged

Zclhlmgqzc mentioned this pull request Mar 5, 2021

__spread Performance Issues #125

Open

Gusted mentioned this pull request Mar 7, 2021

Fix compiling API darkreader/darkreader#5190

Merged

AllanZhengYP mentioned this pull request Apr 19, 2021

chore(dep): upgrade typescript to 4.2.4 aws/aws-sdk-js-v3#2280

Merged

snyk-bot mentioned this pull request Apr 27, 2021

[Snyk] Upgrade tslib from 2.1.0 to 2.2.0 SalesforceCommerceCloud/commerce-sdk#327

Merged

renovate-config-app bot mentioned this pull request Jun 11, 2021

Update dependency tslib to v2 AndersRunningen/toolbox-reference-angular#99

Merged

1 task

iChenLei mentioned this pull request Jun 23, 2021

chore: upgrade typescript/eslint related dependencies, drop node8 and add node16 CI support less/less.js#3628

Merged

This was referenced Jun 30, 2021

Update dependency tslib to v2.3.0 gregplaysguitar/react-object-input#28

Merged

chore(deps): update dependency tslib to v2 dwightjack/yuzu#35

Open

pioter-pioter mentioned this pull request Jul 6, 2021

Update dependency tslib to v2 pioter-pioter/maply#35

Closed

1 task

mend-for-github.aaakk.us.kg bot mentioned this pull request Jul 7, 2021

Update dependency tslib to v2 wrbejar/LeakyAngularFromNotebook#127

Open

1 task

efokschaner mentioned this pull request Jul 12, 2021

Specify required version of tslib ^2.0.0 antvis/algorithm#31

Merged

mend-for-github.aaakk.us.kg bot mentioned this pull request Jul 14, 2021

Update dependency tslib to v2 joshnewton31080/Angular-1#38

Open

1 task

This was referenced Jul 24, 2021

Update dependency tslib to v2 spences10/react-seo-component#111

Merged

Update dependency tslib to v2 hillnz/deadtous#19

Open

renovate bot mentioned this pull request Aug 5, 2021

Update dependency tslib to v2 weikangchia/op-converter#11

Merged

1 task

jcesarioatpeach mentioned this pull request Jun 26, 2023

[Snyk] Upgrade tslib from 2.0.0 to 2.5.3 peachfinance/redoc#5

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update tslib to support new __spreadArray helper #133

Update tslib to support new __spreadArray helper #133

rbuckton commented Nov 13, 2020 •

edited

Loading

rbuckton commented Nov 13, 2020

ExE-Boss Nov 13, 2020

rbuckton Dec 18, 2020

ExE-Boss commented Nov 15, 2020

orta commented Nov 18, 2020

orta commented Nov 18, 2020

orta left a comment

rbuckton commented Dec 18, 2020

Finesse commented Feb 11, 2021

ExE-Boss commented Feb 11, 2021 •

edited

Loading

		export declare function __spreadArrays(...args: any[][]): any[];
		export declare function __spreadArray(to: any[], from: any[]): any[];

	export declare function __spreadArray(to: any[], from: any[]): any[];
	export declare function __spreadArray<T, U>(to: T[], from: ReadonlyArray<U>): Array<T \| U>;

Update tslib to support new __spreadArray helper #133

Update tslib to support new __spreadArray helper #133

Conversation

rbuckton commented Nov 13, 2020 • edited Loading

rbuckton commented Nov 13, 2020

ExE-Boss Nov 13, 2020

Choose a reason for hiding this comment

rbuckton Dec 18, 2020

Choose a reason for hiding this comment

ExE-Boss commented Nov 15, 2020

orta commented Nov 18, 2020

orta commented Nov 18, 2020

orta left a comment

Choose a reason for hiding this comment

rbuckton commented Dec 18, 2020

Finesse commented Feb 11, 2021

ExE-Boss commented Feb 11, 2021 • edited Loading

rbuckton commented Nov 13, 2020 •

edited

Loading

ExE-Boss commented Feb 11, 2021 •

edited

Loading