fix: Add dummy location data to conform to SARIF spec #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 87341d8.
…-sarif-converter into add-dummy-location
DaveTryon
commented
May 9, 2023
| @@ -15,7 +15,7 @@ import { EnvironmentData } from './environment-data'; | |||
| import { getInvocations } from './invocation-provider'; | |||
| import { ResultToRuleConverter } from './result-to-rule-converter'; | |||
| import { formatSarifResultMessage } from './sarif-result-message-formatter'; | |||
| import { axeTagsToWcagLinkData, WCAGLinkData } from './wcag-link-data'; | |||
| import { WCAGLinkData, axeTagsToWcagLinkData } from './wcag-link-data'; | |||
There was a problem hiding this comment.
Something seems to have changed in prettier
DaveTryon
commented
May 9, 2023
| @@ -15,7 +15,7 @@ import { getEnvironmentDataFromResults } from './environment-data-provider'; | |||
| import { getInvocations } from './invocation-provider'; | |||
| import { ResultToRuleConverter } from './result-to-rule-converter'; | |||
| import { formatSarifResultMessage } from './sarif-result-message-formatter'; | |||
| import { axeTagsToWcagLinkData, WCAGLinkData } from './wcag-link-data'; | |||
| import { WCAGLinkData, axeTagsToWcagLinkData } from './wcag-link-data'; | |||
There was a problem hiding this comment.
Something seems to have changed in prettier
dbjorge
approved these changes
May 16, 2023
|
🎉 This PR is included in version 2.10.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
As called out in #961, our SARIF doesn't have a fully formed location. Since we don't have meaningful data for this, the "least bad" solution was to insert dummy data for the
startLineproperty. This PR includes 2 code changes, plus a bunch of refreshed SARIF files generated via the CLI tool. I noticed that the refreshed version ofbasic-axe-3.2.2.sarifis pretty-printed differently than what we had before. I'm guessing that the tool shifted at some point and that this is the first time the file has been regenerated with the current tool.Motivation
Address #961 for better tool compatibility
Context
Pull request checklist
fix:,feat:, etc, and is suitable for user-facing release notes)BREAKING CHANGE:yarn precheckin