Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArduCopterSolo support #1387

Merged
merged 4 commits into from
Oct 9, 2018

Conversation

KerryMoffittRtn
Copy link
Contributor

Support for the 3DR Solo quadrotor, which uses a fork of ArduPilot ( https://github.com/3drobotics/ardupilot-solo ) for its autopilot, and ad hoc UDP links (pushing FlightGear FDM messages) for sensor data and rotor control flow in SIL mode

KerryMoffittRtn and others added 4 commits September 10, 2018 14:09
See also https://github.com/3drobotics/ardupilot-solo

Along the way:
- Let MultiRotorParamsFactory issue Solo IDs (for independent
connections to ArduPilot instances)
- Rename the now-shared 'PX4VehicleSetting' to 'MavLinkVehicleSetting'
- Promote some MavLinkMultirotorApi members and methods from private to
protected
(Movement seems to be slightly jerky compared to pre-refactor, but I'm
not spending much time on this since the commentary suggests that others
are already thinking about The Right Way to do it.)
@sytelus sytelus merged commit 762a635 into microsoft:master Oct 9, 2018
sytelus added a commit that referenced this pull request Oct 9, 2018
@sytelus
Copy link
Contributor

sytelus commented Oct 9, 2018

Hi Kerry,

I've merged this PR with 2 changes the top:

  1. I removed these lines because it does double update. Could you please clarify why you needed this? GPS for MavLink seems to work fine.

  2. Removed next_solo_id_. I think it's not a good idea to use this kind of variable to set up port numbers. The port numbers generated like this may conflict with something else or may not even be allowed due to firewall. The port numbers should come from config files or function parameters as good practice. Once we remove this field, we also don't need change for having separate cpp file.

You can see these changes in this commit.

Would it be possible to add a small doc file (.md file in docs folder) on how to use this functionality?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants