Put failing tests behind ActiveIssue (dotnet#852)

MichalStrehovsky · Mar 25, 2021 · 09d75d0 · 09d75d0
1 parent 4564ad6
commit 09d75d0
Show file tree

Hide file tree

Showing 8 changed files with 18 additions and 1 deletion.
diff --git a/src/coreclr/nativeaot/System.Private.CoreLib/src/System/Enum.CoreRT.cs b/src/coreclr/nativeaot/System.Private.CoreLib/src/System/Enum.CoreRT.cs
@@ -222,7 +222,7 @@ public static string[] GetNames(Type enumType)
                 return enumType.GetEnumNames();
 
             if (!enumType.IsEnum)
-                throw new ArgumentException(SR.Arg_MustBeEnum);
+                throw new ArgumentException(SR.Arg_MustBeEnum, nameof(enumType));
 
             string[] ret = GetEnumInfo(enumType).Names;
 

diff --git a/src/libraries/System.Runtime/tests/System/AttributeTests.cs b/src/libraries/System.Runtime/tests/System/AttributeTests.cs
@@ -154,6 +154,8 @@ class ChildAttributeWithField : ParentAttribute
             public int Field = 0;
         }
 
+
+        [ActiveIssue("https://github.com/dotnet/runtimelab/issues/803" /* NativeAot */)]
         [Fact]
         [StringValue("\uDFFF")]
         public static void StringArgument_InvalidCodeUnits_FallbackUsed()

diff --git a/src/libraries/System.Runtime/tests/System/Diagnostics/StackTraceHiddenAttributeTests.cs b/src/libraries/System.Runtime/tests/System/Diagnostics/StackTraceHiddenAttributeTests.cs
@@ -17,6 +17,7 @@ public void Ctor()
 
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtimelab/issues/851" /* NativeAot */)]
         public void MethodHidden_ExceptionStackTrace()
         {
             string stacktrace = null;
@@ -49,6 +50,7 @@ public void MethodHidden_ExceptionStackTrace()
 
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtimelab/issues/851" /* NativeAot */)]
         public void MethodHidden_EnvironmentStackTrace()
         {
             string stacktrace = GetStackTraceMethodA();
@@ -69,6 +71,7 @@ public void MethodHidden_EnvironmentStackTrace()
 
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtimelab/issues/851" /* NativeAot */)]
         public void ConstructorHidden_EnvironmentStackTrace()
         {
             Assert.Contains(nameof(NotHiddenConstructor), new NotHiddenConstructor().StackTrace);
@@ -94,6 +97,7 @@ private class HiddenConstructor
 
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtimelab/issues/851" /* NativeAot */)]
         public void ClassHidden_EnvironmentStackTrace()
         {
             string stacktrace = HiddenClass.GetStackTraceMethodA();
@@ -117,6 +121,7 @@ internal class HiddenClass
 
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtimelab/issues/851" /* NativeAot */)]
         public void StructHidden_EnvironmentStackTrace()
         {
             string stacktrace = new HiddenStruct().GetStackTraceMethodA();

diff --git a/src/libraries/System.Runtime/tests/System/PseudoCustomAttributeTests.cs b/src/libraries/System.Runtime/tests/System/PseudoCustomAttributeTests.cs
@@ -13,6 +13,7 @@ namespace System.Tests
 {
     public static partial class PseudoCustomAttributeTests
     {
+        [ActiveIssue("https://github.com/dotnet/runtimelab/issues/830" /* NativeAot */)]
         [Theory]
         [MemberData(nameof(TestData_AttributeExists))]
         [MemberData(nameof(TestData_AttributeDoesNotExist))]
@@ -38,6 +39,7 @@ public static void IsDefined(object target, Type attributeType, Attribute attrib
             }
         }
 
+        [ActiveIssue("https://github.com/dotnet/runtimelab/issues/830" /* NativeAot */)]
         [Theory]
         [MemberData(nameof(TestData_AttributeExists))]
         [MemberData(nameof(TestData_AttributeDoesNotExist))]
@@ -63,6 +65,7 @@ public static void GetCustomAttribute(object target, Type attributeType, Attribu
             }
         }
 
+        [ActiveIssue("https://github.com/dotnet/runtimelab/issues/830" /* NativeAot */)]
         [Theory]
         [MemberData(nameof(TestData_AttributeExists))]
         [MemberData(nameof(TestData_AttributeDoesNotExist))]

diff --git a/src/libraries/System.Runtime/tests/System/Reflection/InvokeWithRefLikeArgs.cs b/src/libraries/System.Runtime/tests/System/Reflection/InvokeWithRefLikeArgs.cs
@@ -17,6 +17,7 @@ public static void MethodReturnsRefToRefStruct_ThrowsNSE()
         }
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtimelab/issues/155" /* NativeAot */)]
         public static void MethodTakesRefStructAsArg_DoesNotCopyValueBack()
         {
             MethodInfo mi = GetMethod(nameof(TestClass.TakesRefStructAsArg));
@@ -28,6 +29,7 @@ public static void MethodTakesRefStructAsArg_DoesNotCopyValueBack()
         }
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtimelab/issues/155" /* NativeAot */)]
         public static void MethodTakesRefStructAsArgWithDefaultValue_DoesNotCopyValueBack()
         {
             MethodInfo mi = GetMethod(nameof(TestClass.TakesRefStructAsArgWithDefaultValue));
@@ -77,6 +79,7 @@ public static void PropertyTypedAsRefToRefStruct_AsPropInfo_ThrowsNSE()
         }
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtimelab/issues/155" /* NativeAot */)]
         public static void PropertyIndexerWithRefStructArg_DoesNotCopyValueBack()
         {
             PropertyInfo pi = typeof(TestClassWithIndexerWithRefStructArg).GetProperty("Item");

diff --git a/src/libraries/System.Runtime/tests/System/Runtime/CompilerServices/RuntimeHelpersTests.cs b/src/libraries/System.Runtime/tests/System/Runtime/CompilerServices/RuntimeHelpersTests.cs
@@ -273,6 +273,7 @@ static ClassWithNormalCctor()
             }
         }
 
+        [ActiveIssue("https://github.com/dotnet/runtimelab/issues/155" /* NativeAot */)]
         [Fact]
         public static void GetUninitalizedObject_DoesNotRunBeforeFieldInitCctors()
         {

diff --git a/...aries/System.Runtime/tests/System/Runtime/ExceptionServices/ExceptionDispatchInfoTests.cs b/...aries/System.Runtime/tests/System/Runtime/ExceptionServices/ExceptionDispatchInfoTests.cs
@@ -29,6 +29,7 @@ public static void StaticThrow_UpdatesStackTraceAppropriately()
         }
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtimelab/issues/831" /* NativeAot */)]
         public static void SetCurrentStackTrace_Invalid_Throws()
         {
             Exception e;
@@ -49,6 +50,7 @@ public static void SetCurrentStackTrace_Invalid_Throws()
         }
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtimelab/issues/831" /* NativeAot */)]
         public static void SetCurrentStackTrace_IncludedInExceptionStackTrace()
         {
             Exception e;

diff --git a/src/libraries/System.Runtime/tests/System/Type/TypeTests.cs b/src/libraries/System.Runtime/tests/System/Type/TypeTests.cs
@@ -527,6 +527,7 @@ public void GetTypeByName_Invalid(string typeName, Type expectedException, bool
         }
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtimelab/issues/155" /* NativeAot */)]
         public void GetTypeByName_InvokeViaReflection_Success()
         {
             MethodInfo method = typeof(Type).GetMethod("GetType", new[] { typeof(string) });
-Original file line number
+Diff line change
@@ Expand Up / @@ -273,6 +273,7 @@ static ClassWithNormalCctor() @@
                 }
             }
+            [ActiveIssue("https://github.com/dotnet/runtimelab/issues/155" /* NativeAot */)]
             [Fact]
             public static void GetUninitalizedObject_DoesNotRunBeforeFieldInitCctors()
             {
@@ Expand Down @@