Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dietpi-Letsencrypt issue #4336

Closed
staxfax opened this issue May 3, 2021 · 1 comment · Fixed by #4337
Closed

Dietpi-Letsencrypt issue #4336

staxfax opened this issue May 3, 2021 · 1 comment · Fixed by #4337
Labels
Bug 🐞 Solution available 🥂 Definite solution has been done
Milestone
v7.2

Comments

@staxfax
Copy link

staxfax commented May 3, 2021

Details:

  • Date | Mon May 3 16:36:57 CEST 2021
  • DietPi version | v7.1.2 (MichaIng/master)
  • Image creator | DietPi Core Team
  • Pre-image | Raspberry Pi OS Lite (64-bit)
  • Hardware | RPi 4 Model B (aarch64) (ID=4)
  • Kernel version | Linux STAX-RPF 5.10.17-v8+ DietPi-Config | Minor NTP enhancements #1403 SMP PREEMPT Mon Feb 22 11:37:54 GMT 2021 aarch64 GNU/Linux
  • Distro | buster (ID=5,RASPBIAN=0)
  • Command | lighty-enable-mod dietpi-https
  • Exit code | 2
  • Software title | DietPi-LetsEncrypt

Steps to reproduce:

  1. ...
  2. ...

Expected behaviour:

  • ...

Actual behaviour:

  • ...

Extra details:

  • ...

Additional logs:

already enabled
Run "service lighttpd force-reload" to enable changes
@staxfax staxfax closed this as completed May 3, 2021
@MichaIng MichaIng added this to the v7.2 milestone May 3, 2021
@MichaIng MichaIng reopened this May 3, 2021
@MichaIng
Copy link
Owner

MichaIng commented May 3, 2021 •
edited
Loading

Many thanks for your report. While you can ignore the error and override it by changing the command to "true" or ":", it is a bug, since it is known that this command produces an error code when a Lighttpd config is enabled already. I'll fix it by accepting the particular exit code checking first whether the config is enabled or disabled currently.

Done: #4337

@MichaIng MichaIng linked a pull request May 3, 2021 that will close this issue
DietPi-LetsEncrypt | Lighttpd: Resolve lighty-*-mod errors #4337
Merged
@MichaIng MichaIng added the Solution available 🥂 Definite solution has been done label May 3, 2021
This was referenced May 22, 2021
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🐞 Solution available 🥂 Definite solution has been done
Projects
None yet
Milestone
v7.2
Development

Successfully merging a pull request may close this issue.

DietPi-LetsEncrypt | Lighttpd: Resolve lighty-*-mod errors MichaIng/DietPi
2 participants
@MichaIng @staxfax