Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DietPi-Software | Remove mandatory reboot after installs #4032

Closed
Games-Crack opened this issue Jan 2, 2021 · 4 comments · Fixed by #4095
Closed

DietPi-Software | Remove mandatory reboot after installs #4032

Games-Crack opened this issue Jan 2, 2021 · 4 comments · Fixed by #4095
Milestone

Comments

@Games-Crack
Copy link

Is your feature request related to a problem? Please describe:

I am always frustrated when I install software on my diet pi with dietpi-software because I can't say no to the reboot!

Describe the solution you'd like:

Let the user decide if he/she wants to reboot

Describe alternatives you've considered:

Or a "Flag" that you can set to not reboot

@Joulinar
Copy link
Collaborator

Joulinar commented Jan 2, 2021

Hi,

you can avoid the reboot by using dietpi-software install <ID> but I guess @MichaIng can explain the reason for the reboot required 😉

@MichaIng
Copy link
Owner

MichaIng commented Jan 3, 2021

Good news is I just thought the same a few days ago: There is not really a reason for the reboot, probably required in a very few cases only. It's just that it was there as long as I can think of and no one aimed to remove it until now.

Let's remove it. In a few cases we might want to start the respective software service one time manually (for those which are not controlled by dietpi-services): VPN and VNC servers + XRDP, SSH servers, NoMachine, hostapd, that should be it.

In case of WireGuard, if the kernel got upgraded in the same turn, a reboot is required to allow it starting. But in case of dietpi-software install 172 with upgraded kernel we already print a related info message that we could make a bid "larger".

@MichaIng MichaIng added this to the v6.35 milestone Jan 3, 2021
@MichaIng MichaIng changed the title Rebooting Every time i install a software bugs me! DietPi-Software | Remove mandatory reboot after installs Jan 3, 2021
@Games-Crack
Copy link
Author

@Joulinar I know that you sometimes have to reboot ;-)
but not all the time like @MichaIng said and thank you for the command i didn't know this.

@MichaIng MichaIng linked a pull request Feb 8, 2021 that will close this issue
@MichaIng MichaIng added the Solution available 🥂 Definite solution has been done label Feb 9, 2021
@MichaIng
Copy link
Owner

MichaIng commented Feb 9, 2021

Done: #4095

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants