Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DietPi-Software | Pi-hole: Add version 5 support #3391

Closed
maartenlangeveld opened this issue Feb 24, 2020 · 15 comments
Closed

DietPi-Software | Pi-hole: Add version 5 support #3391

maartenlangeveld opened this issue Feb 24, 2020 · 15 comments
Labels
Enhancement 💨 Solution available 🥂 Definite solution has been done
Milestone

Comments

@maartenlangeveld
Copy link

Just testing Pihole v5 (beta), in order to add domains (blacklist, whitelist) through pihole's web interface, user 'www-data' needs to be part of 'pihole' group.

@MichaIng MichaIng changed the title Pi-hole v5 needs 'www-data' user added to 'pihole' group DietPi-Software | Pi-hole: Add version 5 support Feb 24, 2020
@MichaIng MichaIng added this to the v6.29 milestone Feb 24, 2020
@MichaIng
Copy link
Owner

@maartenlangeveld
Many thanks for your report. Yes indeed there is also some more testing and tweaking required/possible with v5. I'll do that the next days, the new pihole group is already good to know.

@maartenlangeveld
Copy link
Author

maartenlangeveld commented Feb 24, 2020 via email

@MichaIng
Copy link
Owner

@maartenlangeveld
Many thanks for testing. Could you please try to edit /boot/armbianEnv.txt and add:
i2c0 to the overlays line, so it should look like this:

overlays=usbhost1 usbhost2 i2c0

There is also an i2c1 overlay available, not sure which one uses which pins.
And if you don't use Docker, add the following as new line as well, which should lead to minor performance enhancements:

docker_optimizations=off

@maartenlangeveld
Copy link
Author

@MichaIng

That works! Thanks again for your truly great support !!

@Joulinar
Copy link
Collaborator

Joulinar commented Mar 2, 2020

just for reference regarding PiHole v5

https://discourse.pi-hole.net/t/error-message-attempt-to-write-a-readonly-database/27092/17

usermod -a -G pihole www-data

@MichaIng
Copy link
Owner

MichaIng commented Mar 2, 2020

@Joulinar
Jep many thanks. Will run some further tests the next days, I think there are more things that should be adjusted for Pi-hole v5 compatibility.

@MichaIng
Copy link
Owner

MichaIng commented Mar 7, 2020

Done: b90b49f
Changelog: d5a44d0

@Joulinar
Copy link
Collaborator

Joulinar commented Mar 8, 2020

@MichaIng
I guess it will impact new installation only? Right?
What about existing installation? Should we do anything on it as well?

@MichaIng
Copy link
Owner

MichaIng commented Mar 8, 2020

@Joulinar
Good point. We can check on update if dietpi group exists and in case add www-data user to it.

@MichaIng
Copy link
Owner

Pi-hole v5 as well depends on PHP intl module now: c18f6c6

@MichaIng
Copy link
Owner

v5 compatibility guaranteed with next DietPi-Update: 9dc9596

@Joulinar
Copy link
Collaborator

@MichaIng
I tested 2 scenario on my Buster VM

  1. upgrade from v6.28 to v6.29 with an already existing PiHole installation
  2. install new PiHole on v6.29

Both are working fine and PiHole 5 was working ootb after upgrade.

@MichaIng
Copy link
Owner

@Joulinar
That is great, many thanks for testing.

@MichaIng MichaIng mentioned this issue Mar 30, 2020
@mistakenideas
Copy link

Tested upgrading from DietPi 6.28 to 6.29 on RaspberryPi B Rev 1. Only really running Pi-Hole 4 on this which I then switched to the Pi-Hole 5 Beta branch. All seems to be running okay so far.

@MichaIng
Copy link
Owner

MichaIng commented May 3, 2020

@mistakenideas
Many thanks for testing ❤️.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement 💨 Solution available 🥂 Definite solution has been done
Projects
None yet
Development

No branches or pull requests

4 participants