DietPi-Software | O!MPD: New (Buster+ARMv6) Lighttpd config breaks "Now Playing" page

[maartenlangeveld]

@MichaIng

Hi Micha,

With the new lighttpd version in v6.24, there is also a new lighhtpd.conf config file shipped.
This breaks one specific webpage ('Now Playing') under a specific condition (empty playlist): "400 Bad Request" when clicking ('Now Playing') oon O!MPD startpage.

After som trial and error I managed to discover which element in the new config file was the cause. Just to let you know:

New version lighttpd added following lines to lighttpd.conf.
When I disable "url-ctrls-reject" the "Now Playing" page in O!MPD page loads again when playlist is empty. If enabled (as default with new lighttpd versions), I get ""400 Bad Request" error message.

# strict parsing and normalization of URL for consistency and security
# https://redmine.lighttpd.net/projects/lighttpd/wiki/Server_http-parseoptsDetails
# (might need to explicitly set "url-path-2f-decode" = "disable"
#  if a specific application is encoding URLs inside url-path)
server.http-parseopts = (
  "header-strict"           => "enable",# default
  "host-strict"             => "enable",# default
  "host-normalize"          => "enable",# default
  "url-normalize-unreserved"=> "enable",# recommended highly
  "url-normalize-required"  => "enable",# recommended
 #"url-ctrls-reject"        => "enable",# recommended -->Disabled. breaks O!MPD 'Now Playing' when playlist is emtpy.
  "url-path-2f-decode"      => "enable",# recommended highly (unless breaks app)
 #"url-path-2f-reject"      => "enable",
  "url-path-dotseg-remove"  => "enable",# recommended highly (unless breaks app)
 #"url-path-dotseg-reject"  => "enable",
 #"url-query-20-plus"       => "enable",# consistency in query string
)

[MichaIng]

@maartenlangeveld
Many thanks for reporting and providing the solution.

Will have to check what this setting actually does. Also we currently ship an outdated version of O!MPD due to database sync errors with the (that time) current one. But will retest this and perhaps the new version works with new Lighttpd defaults as well.
The same might be true for myMPD.

[maartenlangeveld]

Hi @MichaIng,

Have just checked latest O!MPD version (git clone from O!MPD github repo). Works fine at first sight. No databases errors. Plays my music catalogue and streams (radio) as well. At first sight seems okay with me.

[MichaIng]

@maartenlangeveld
Thanks for testing. Have to find the existing issues about that. Fourdee faced the issues that time, at best he can verify it works now to have the device/setup tested that failed.

I will also test on VM and RPi now.

[maartenlangeveld]

@MichaIng @Fourdee

Meanwhile has been solved by O!MPD @ArturSierzant (many thanks !) in O!MPD GitHub master

[MichaIng]

Jep fixed in latest master, although we generally should go with latest release. Here is how we'll do it: ArturSierzant/OMPD#86 (comment)

Further optimisations: ArturSierzant/OMPD#86 (comment)

[MichaIng]

PR up: #2884