Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please do not overwrite mpd.conf with every update! #2472

Closed
maartenlangeveld opened this issue Jan 30, 2019 · 4 comments
Closed

Please do not overwrite mpd.conf with every update! #2472

maartenlangeveld opened this issue Jan 30, 2019 · 4 comments

Comments

@maartenlangeveld
Copy link

Just updated from v6.20.5 to v6.20,6 my rpi-zero-w music streamer with Justboom Zero HAT. The faulty mpd.conf (that I edited manually in order to work correctly) gets again overwritten.... argh

@MichaIng
Copy link
Owner

MichaIng commented Jan 30, 2019

@maartenlangeveld
But there was a backup of your manually adjusted mpd.conf, wasn't it?
It should be /etc/mpd.conf.bak_30012019 or similar.

What you mean by "faulty mpd.conf"? Is there an issue with the default mpd.conf DietPi-Software ships, or do you just need to configure to your individual needs?

@maartenlangeveld
Copy link
Author

Faulty by means that MPD cannot open alsa sound card when running as user "mpd" have to change back to "user" root. There was a backup. But would be nice if config is not overwritten, unless there''s a need for it.

@MichaIng
Copy link
Owner

MichaIng commented Jan 30, 2019

@maartenlangeveld
Okay good to know. I am a bid wondering how this is solved with the default Debian package, where MPD runs as non-root as well. But perhaps is is there an issue as well.

Yeah about the config file overwriting, in many cases we handle this already different now, preserve existing settings and only inject single settings that are required. However in case of mpd.conf it is a bid difficult, due to the complexity of the file and it's syntax. It is impossible (or high effort with high failure chance) to apply all required settings just via sed and such. If we leave it completely untouched, on fresh install users face issues as well. so we apply the default config, which should work well in most cases and instead create the backup, in case users made manual adjustments. But yeah the root requirement needs to be investigated, as you already opened a separate issue about this.

@MichaIng MichaIng added this to the v6.21 milestone Jan 30, 2019
@Fourdee
Copy link
Collaborator

Fourdee commented Feb 2, 2019

G_BACKUP_FP rolled out for MPD. Will mark this as closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants