-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DietPi-Software | Pi-hole: Add support for blocking page #2007
Comments
Quick fix attempt to symlink either
or
as without further configuration, blocks are redirected to webroot and this is finally the same that we did before with out own I can test later at night, currently at work and late buying needed afterwards 🤣. |
@Fourdee Pi-hole starts now automatically. The only thing I did additionally was About the blockpage: With this also the 404 forward to blocking page is not needed. Not sure if it still makes sense or in which case a block actually returns 404 (instead of redirecting back to host/webroot). But the other /admin/ folder additions to Lighttpd should be added with our install step to Lets still add this to 6.13 to have a complete Lighttpd experience for end users. |
Strange, will retest with web access. Can't be that hard. So issue not yet resolved right? I reopen for v6.14 |
Okay, long testing up and down. 🈯️ Enabling blocking page from Pi-hole system, starting from our install (with Lighttpd):
Now accessing a blocked page, shows the new blocking page.
🈴 I tried the whole night to enable blocking page for other systems that use Pi-hole server as DNS. Pages are blocked as expected, but no blocking page shows up. |
I also had the same issue after upgrading pihole to 4.0. I had to restore to previous version 3.x. |
Can someone verify, that Pi-hole does not show blocking page on clients? I tested again. Blocked pages are redirected by Pi-hole DNS server to 0.0.0.0.
On the server, 0.0.0.0 is redirected to localhost, which is blocking page on Pi-hole default install or DietPi install with above steps:
I tried it as said with official Pi-hole install method and also had no blocking page on clients. If someone can prove it on different network setup, then this is properly a bug, or missing feature that would be actually easy to implement:
|
I think behaviour changed in version 4 of pihole. See the docs on blocking modes |
@bboffey So default is I mark this as no DietPi issue then. Also when blocking page does by default not show up on clients, does it make sense to enable it for the Pi-hole server machine then? A bid inconsistent? But the question really is now if we want to overwrite default and enable blocking page (for clients and server) or not. If it's about ads blocking that are embedded with web pages, then the connection attempt itself is really unnecessary indeed. On pop-ups and if you simply want to disallow access to certain not advertising-only web pages within your local network (tracking social media, unwanted search sites and such 😄), then a blocking page is quite informative and helpful for users. Or we add a whiptail menu to ask users? This would be cool to have within Pi-holes own install script, but we could add it ourself (before/after we inform user about changed web UI login password) while waiting for Pi-hole to decide over PR implementation? This is properly the best solution here? |
@Fourdee
|
I would prefer this:
So, durning setup whiptail, menu ask user to for his choice. |
@k-plan I would then just offer to choose between Enable and Disable blocking page, which then does it for server (see the needed symlinks above), as well as clients. Use |
👍 yes, spot-on. |
Tests:
|
@Fourdee
Strange, web UI was not even installed:
Is |
Same error with admin. html folder missing?
|
More stange:
And webUI + blocking page works now. Note to self: symlinks got backup, which should not be done if those match the ones created. |
Yep, just did the same lol 👍 |
Apache2 APT install, generates its own html dir:
Pihole install, pre-our-config
|
During Apache configuration we do:
@Fourdee |
So not yet like a charm 😄.
??? So |
I believe Install vars are in
So, is the issue Pi-hole ignoring the var, or, something our end, needs further testing/debugging. |
@Fourdee |
I think I was mistaken, the pihole-FTL.conf is clearly initiated as empty file```
Hmm what is the difference:
🈯️ Retested with VM Stretch Pi-hole server and VM Jessie client. Installed LXDE and accessed manually blocked domain. Blocking page showed up correctly 🤔. |
C2, ASUS TB , both stretch. Will re-run the tests. |
Still not working for me:
Could be a DNS cache issue my end.
Works with local system only? |
|
@Fourdee I will retest with production RPi as client and Windows system. Already wanted to, but outdated/broken VMware and/or VirtualBox network drivers didn't allow to change any adapter setting (error thrown on apply), until full purged and reinstalled both VM software + full network adapter reset 🙄. |
Retest with ASUS TB and block page:
Seems only local system has functional blocking page. |
@Fourdee
|
Might be a DNS cache/routing issue my end. Ok, retest:
Seems https is not redirected to blocking page. Verified results in Chromium. Known issue, requires SSL cert on Pi-hole server? https://discourse.pi-hole.net/t/enabling-https-for-your-pi-hole-web-interface/5771
🈯️ Confirmed known limitation with HTTPS blocking: |
The text was updated successfully, but these errors were encountered: