NFS v3 disable feature description added, Flask link correction #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanStS
added
enhancement
obn100
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Nice update, as already described in your article https://dietpi.com/blog/?p=3581#improving_security
Tested the script to deactivate v3, works fine on a vanilla DietPi Proxmox VM with installed nfs server
MichaIng
reviewed
Nov 3, 2024
MichaIng
reviewed
Nov 3, 2024
MichaIng
reviewed
Nov 3, 2024
MichaIng
reviewed
Nov 3, 2024
MichaIng
reviewed
Nov 3, 2024
MichaIng
reviewed
Nov 3, 2024
MichaIng
reviewed
Nov 3, 2024
Co-authored-by: MichaIng <[email protected]>
Co-authored-by: MichaIng <[email protected]>
Co-authored-by: MichaIng <[email protected]>
Co-authored-by: MichaIng <[email protected]>
Co-authored-by: MichaIng <[email protected]>
Co-authored-by: MichaIng <[email protected]>
Co-authored-by: MichaIng <[email protected]>
MichaIng
approved these changes
Nov 3, 2024
|
Great to have this covered. Still wondering whether we should disable it by default (and invert this docs section). Not sure how widely NFSv3 only clients are still used, and whether all modern clients use NFSv4 by default, so that the performance benefit of NFSv3 never comes into play, unless users do manual changes at client side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.