Fix/getBins doesnt work correctly if more than 2 bin arrays

CHANGELOG.md

@@ -19,6 +19,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Security
 
+## @meteora-ag/dlmm [1.2.4] - PR #116
+
+### Fixed
+
+- Fixed `getBins` incorrect bin array index to fetch
+
 ## @meteora-ag/dlmm [1.2.3] - PR #112
 
 ### Fixed

ts-client/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@meteora-ag/dlmm",
-  "version": "1.2.3",
+  "version": "1.2.4",
   "description": "",
   "main": "./dist/index.js",
   "module": "./dist/index.mjs",

ts-client/src/dlmm/index.ts

@@ -2413,9 +2413,13 @@ export class DLMM {
     const strategyParameters: LiquidityParameterByStrategy["strategyParameters"] =
       toStrategyParameters(strategy) as ProgramStrategyParameter;
 
-    const positionAccount = await this.program.account.positionV2.fetch(positionPubKey);
+    const positionAccount = await this.program.account.positionV2.fetch(
+      positionPubKey
+    );
 
-    const lowerBinArrayIndex = binIdToBinArrayIndex(new BN(positionAccount.lowerBinId));
+    const lowerBinArrayIndex = binIdToBinArrayIndex(
+      new BN(positionAccount.lowerBinId)
+    );
     const upperBinArrayIndex = lowerBinArrayIndex.add(new BN(1));
 
     const [binArrayLower] = deriveBinArray(
@@ -5293,24 +5297,17 @@ export class DLMM {
         }
       });
     } else {
-      const [lowerBinArrayPubKey] = deriveBinArray(
-        lbPairPubKey,
-        lowerBinArrayIndex,
-        this.program.programId
-      );
-      const [upperBinArrayPubKey] = deriveBinArray(
-        lbPairPubKey,
-        upperBinArrayIndex,
-        this.program.programId
-      );
+      const accountsToFetch = [];
+      for (let i = lowerBinArrayIndex.toNumber(); i <= upperBinArrayIndex.toNumber(); i++) {
+        accountsToFetch.push(
+          deriveBinArray(lbPairPubKey, new BN(i), this.program.programId)[0]
+        )
+      }
 
       const binArrays = await (async () => {
         if (!lowerBinArrays || !upperBinArrays) {
           return (
-            await this.program.account.binArray.fetchMultiple([
-              lowerBinArrayPubKey,
-              upperBinArrayPubKey,
-            ])
+            await this.program.account.binArray.fetchMultiple(accountsToFetch)
           ).filter((binArray) => binArray !== null);
         }
 
@@ -5319,9 +5316,8 @@ export class DLMM {
 
       binArrays.forEach((binArray) => {
         if (!binArray) return;
-        const [lowerBinIdForBinArray] = getBinArrayLowerUpperBinId(
-          binArray.index
-        );
+        const [lowerBinIdForBinArray] =
+          getBinArrayLowerUpperBinId(binArray.index);
         binArray.bins.forEach((bin, idx) => {
           const binId = lowerBinIdForBinArray.toNumber() + idx;
           if (binId >= lowerBinId && binId <= upperBinId) {