-
-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rounding in UIs #619
Rounding in UIs #619
Conversation
@seasnail8169 looks good :3 |
# Conflicts: # src/main/java/minegame159/meteorclient/gui/themes/meteor/MeteorGuiTheme.java
# Conflicts: # src/main/java/minegame159/meteorclient/systems/modules/render/hud/modules/InventoryViewerHud.java
Build failed because pipeline uses java 8 |
# Conflicts: # src/main/java/minegame159/meteorclient/systems/modules/render/hud/modules/CombatHud.java # src/main/java/minegame159/meteorclient/systems/modules/render/hud/modules/InventoryViewerHud.java # src/main/java/minegame159/meteorclient/systems/modules/render/hud/modules/PlayerModelHud.java
# Conflicts: # src/main/java/minegame159/meteorclient/systems/modules/render/hud/HudRenderer.java
# Conflicts: # src/main/java/meteordevelopment/meteorclient/gui/themes/meteor/widgets/WMeteorQuad.java # src/main/java/meteordevelopment/meteorclient/systems/modules/render/hud/HudRenderer.java # src/main/java/meteordevelopment/meteorclient/systems/modules/render/hud/modules/InventoryViewerHud.java
# Conflicts: # src/main/java/meteordevelopment/meteorclient/gui/GuiTheme.java
@seasnail8169 |
what |
merge it or you're a baka |
no |
mfw (my face when) still not accepted |
Maybe add as an option instead of replacing if it isn’t already |
An option to select by how much everything is rounded is shown and set to 0 by default (= no rounding) |
# Conflicts: # src/main/java/meteordevelopment/meteorclient/renderer/Mesh.java
It's possible to make the curves smooth with OpenGL stuff right |
Yea I think so |
TYad8FrPud.mp4This prob was a known issue already but the hover effect overrides the rounded edges |
Already known, however these are things that I am too stupid to fix without large amounts of very bad code |
Ain’t that sigma |
meteor (with sigma font) |
5 month old pr |
It's been so long 🤯 |
cmon lets get this to a year x3 |
Lets get it |
The pr makes the game crash with memory allocation error. "corrupted size vs. prev_size" and sometimes this "java: malloc.c:4259: _int_malloc: Assertion `(unsigned long) (size) >= (unsigned long) (nb)' failed." This happens when you open the accounts screen with the round setting set to 7 and two cracked accounts in the manager after starting the game. Opening the click gui before you open the accounts prevents the game from crashing, however it introduces a new issue when you then close the accounts screen, go to main menu and quit the game using the button in the game. The game will crash with this error: "double free or corruption (out)" and won't let meteor save. Those issues seem to occur only when the round setting is set to 7 only. |
Closing this PR because the GUI is going go get rewritten in the near future and will most probably include rouded corners. |
RIP 😔 |
RIP? Minegame just confirmed gui rewrite that's sexyyy 😳 |
8 months later 😭 |
Uhhhh uhhh 👀 |
🤨 |
Of course this is optional and disabled by default
Changes after my message in discord:
Closes #544