Better Tooltips, Inventory Tweaks language support #5024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nekiplay
changed the title
RacoonDog
suggested changes
Nov 25, 2024
There was a problem hiding this comment.
- dont put formatting codes in the language files, do text styling in code (
Text.translatable()can also take styledTextobjects as template arguments) - add 'meteor-client' somewhere in all of the translation keys
- dont do
Text.literal(I18n.translate()), useText.translatable()
As far as I'm concerned they should be there as it allows resourcepack creators to edit colors
Text.translatable() not support colors in arguments and in language files |
|
Ccc |
Nekiplay
added a commit
to MeteorClientPlus/MeteorPlus
that referenced
this pull request
Dec 28, 2024
|
Now has in Meteor+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Support for different languages for Better Tooltips and Inventory Tweaks
Related issues
None
How Has This Been Tested?
Checklist: