Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add player join/leave messages to Notifier #4952

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

0xTas
Copy link
Contributor

@0xTas 0xTas commented Oct 14, 2024

Type of change

  • Bug fix
  • New feature

Description

This pr adds options to display player join/leave messages in the Notifier module. Includes two different formatting styles, a configurable notification delay, and the option to show only joins, only leaves, neither, or both.

Related issues

Closes #4929

How Has This Been Tested?

A screenshot demonstrating both notification styles:
image

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas.
  • I have tested the code in both development and production environments.

@Wide-Cat Wide-Cat self-requested a review October 16, 2024 14:29
Copy link
Collaborator

@Wide-Cat Wide-Cat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it make more sense to send messages based on receiving a PlayerListS2CPacket or PlayerRemoveS2CPacket instead of caching the player list and comparing it between ticks?

@0xTas
Copy link
Contributor Author

0xTas commented Oct 17, 2024

I suppose it would. How's this?

@0xTas 0xTas requested a review from Wide-Cat October 17, 2024 15:01
@Wide-Cat Wide-Cat merged commit 42fb908 into MeteorDevelopment:master Oct 18, 2024
1 check passed
@0xTas 0xTas deleted the notifier-joins-leaves branch October 26, 2024 05:30
@nickcat325
Copy link
Contributor

Thanks, it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

notifier/better chat setting to show player join/leaves
3 participants