Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve io stream handling #4742

Merged
merged 1 commit into from
Jul 12, 2024
Merged

improve io stream handling #4742

merged 1 commit into from
Jul 12, 2024

Conversation

RacoonDog
Copy link
Contributor

Type of change

  • Bug fix
  • New feature

Description

  • replace printStackTrace calls with slf4j logging
  • make sure InputStream is closed even when an exception is thrown
  • replace manual copying of InputStream into ByteArrayOutputStream with builtin InputStream#readAllBytes and InputStream#transferTo methods

since the buffer size was increased as a result, this also causes the game to launch faster
image

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas.
  • I have tested the code in both development and production environments.

@MineGame159 MineGame159 merged commit d4e047d into MeteorDevelopment:master Jul 12, 2024
1 check passed
@RacoonDog RacoonDog deleted the io-stream-stuff branch July 12, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RacoonDog @MineGame159