Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Criticals not working #4597

Merged
merged 2 commits into from
May 24, 2024
Merged

Conversation

tyrannus00
Copy link
Contributor

@tyrannus00 tyrannus00 commented May 22, 2024

Type of change

  • Bug fix
  • New feature

Description

Fixes Criticals packet/bypass mode.
The bug was introduced in the update to 1.20.5/6 (653eadc)

The issue is that when sending a packet from within the PacketEvent.Send stack, that due to the singleton nature of the event, the packet variable would be changed to the newly sent packet, so that this packet effectively gets sent twice while the original packet, which triggered the event, doesn't get sent.
This caused Criticals in packet or bypass mode to cancel the attack packet and send an additional movement packet instead, and potentially caused issues in other places as well.

How Has This Been Tested?

I tested it myself, and since I am basically reverting to the state before the update this has been tested for years, if you want.

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas.
  • I have tested the code in both development and production environments.

Possibly also fixed other weird packet behavior after 1.20.6 update
@19MisterX98
Copy link
Contributor

dammit. I thought replacing the packet would solve the serverspoof dilemma.
anyways, you should probably revert the rest of the mentioned commit too. Mixin extras is no longer necessary and the comment is simply wrong now.

the brand channel can stay removed. Ill fix serverspoof in another way.

@19MisterX98 19MisterX98 mentioned this pull request May 23, 2024
5 tasks
@Wide-Cat Wide-Cat merged commit 56fbe95 into MeteorDevelopment:master May 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants