Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Fixes Criticals packet/bypass mode.
The bug was introduced in the update to 1.20.5/6 (653eadc)
The issue is that when sending a packet from within the PacketEvent.Send stack, that due to the singleton nature of the event, the packet variable would be changed to the newly sent packet, so that this packet effectively gets sent twice while the original packet, which triggered the event, doesn't get sent.
This caused Criticals in packet or bypass mode to cancel the attack packet and send an additional movement packet instead, and potentially caused issues in other places as well.
How Has This Been Tested?
I tested it myself, and since I am basically reverting to the state before the update this has been tested for years, if you want.
Checklist: