SimpleOptionMixin Update and fix Random Sneaking issue #3145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
doesn't that miss out some important calls in the actual set method for option |
|
This PR works. Fixes issue #3113. |
Good. |
hexadecimal233
changed the title
|
I love the man who is making this PR. Please pull it. I have built it, and it works 100% correct. |
There is no reason not to merge this 🤔 |
|
How tf does this fix the random sneaking issue |
keybind is related to simpleoptions The old mixin changes the code a lot |
Idk, but I compiled meteor with changes from this PR, and now it is working correctly. |
|
2 weeks passed still open rip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.