Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed id check for objects #293

Merged
merged 1 commit into from
Apr 6, 2016

Conversation

ivan133
Copy link
Contributor

@ivan133 ivan133 commented Mar 24, 2016

Please merge it.
I think I've fixed this issue #277 (comment)

The problem was with underscore's without method and MongoObjects as ids.

@dancastellon
Copy link

+1 for this. I'm using Mongo IDs for my collections and with this commit, removals are reactive in my Tabular table, which they previously were not.

@aldeed aldeed merged commit 6635382 into Meteor-Community-Packages:devel Apr 6, 2016
@aldeed
Copy link
Collaborator

aldeed commented Apr 6, 2016

Thanks!

@zealzest
Copy link

This is not fixed correctly, when id is a string, changes (removing) are not correctly reflected in the filteredRecordIds array. I propose changing that line to:
typeof id === "string" ? filteredRecordIds = _.without(filteredRecordIds, id) : filteredRecordIds = _.without(filteredRecordIds, _.findWhere(filteredRecordIds, id));

@alexpyslar
Copy link

@aldeed
can you please merge @zealzest solution?
I'm using string type ids in mongo and it doesn't work for removal.

@ricaragao
Copy link
Member

@alexpyslar , how did you solve the problem? I've the same here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants