-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meteor 3.0 compatibility #741
Conversation
I come to the point to realize there is no way to support both sync and async computations. Since any method call will require async this bubbles down to all functions involved in the validation chain. It's also nearly impossible to break up the existing syn structures and make them partially async using conditional return of Promises, where applicable. It works for the labels but it does not work at all for I therefore will go down the path of making it fully async. Any objections please add here. |
…teor-simple-schema into migrate/3.0
published |
Hi @jankapunkt , is |
Published |
@jankapunkt for lint fixes I would be willing to move to Biome and standardize that across the entire organization. Thoughts? |
@vparpoil no, async validate etc. is a much bigger effort than expected. For now we will only cover Meteor 3.0 compatibility (in terms of versions / dependencies) and tackle full async in another PR |
@StorytellerCZ let's discuss biome in the organization repo / discussions there |
@jankapunkt Any updates on this async computations? |
@aashutoshshr I got stuck by serut/meteor-coverage#95 which blocks most of my conributions right now, since without decent coverage it's really time-consuming and stressful to migrate/refactor code. |
…teor-simple-schema into migrate/3.0
…simple-schema into migrate/3.0
@StorytellerCZ I released a 2.0.0 as of today. It's stable in what it does and resolved the correct 2x/3x versions dependencies. Regarding async compatibility: we should make a vote |
@jankapunkt any updates when this can be released? |
This is now the updated migration base-branch, exceeding #740 / #738
This means all of the following tasks should be done in an own PR, pointing to this one's branch (
migrate/3.0
)