Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meteor 3.0 compatibility #741

Merged
merged 24 commits into from
Nov 21, 2024
Merged

Meteor 3.0 compatibility #741

merged 24 commits into from
Nov 21, 2024

Conversation

jankapunkt
Copy link
Member

@jankapunkt jankapunkt commented Dec 21, 2023

This is now the updated migration base-branch, exceeding #740 / #738
This means all of the following tasks should be done in an own PR, pointing to this one's branch (migrate/3.0)

@jankapunkt jankapunkt linked an issue Dec 21, 2023 that may be closed by this pull request
@jankapunkt
Copy link
Member Author

I come to the point to realize there is no way to support both sync and async computations. Since any method call will require async this bubbles down to all functions involved in the validation chain.

It's also nearly impossible to break up the existing syn structures and make them partially async using conditional return of Promises, where applicable.

It works for the labels but it does not work at all for doValidation which is basically the core validation routine, without making it all async.

I therefore will go down the path of making it fully async. Any objections please add here.

@jankapunkt jankapunkt marked this pull request as draft April 16, 2024 05:34
@jankapunkt
Copy link
Member Author

published 2.0.0-rc300.0 → compatibility with 3.0-rc.2

@vparpoil
Copy link

Hi @jankapunkt , is 2.0.0-rc300.0 already supporting async functions for autoValue ? It doesn't seem to work in my setup.
Thanks !

@StorytellerCZ
Copy link
Member

Published aldeed:[email protected] which should allow for final Meteor 3 compatibility.

@StorytellerCZ
Copy link
Member

@jankapunkt for lint fixes I would be willing to move to Biome and standardize that across the entire organization. Thoughts?

@jankapunkt
Copy link
Member Author

@vparpoil no, async validate etc. is a much bigger effort than expected. For now we will only cover Meteor 3.0 compatibility (in terms of versions / dependencies) and tackle full async in another PR

@jankapunkt jankapunkt marked this pull request as ready for review July 16, 2024 12:37
@jankapunkt
Copy link
Member Author

@StorytellerCZ let's discuss biome in the organization repo / discussions there

.github/workflows/lint-test-publish.yml Outdated Show resolved Hide resolved
package.js Outdated Show resolved Hide resolved
tests-2x/.meteor/release Outdated Show resolved Hide resolved
@aashutoshshr
Copy link

I come to the point to realize there is no way to support both sync and async computations. Since any method call will require async this bubbles down to all functions involved in the validation chain.

It's also nearly impossible to break up the existing syn structures and make them partially async using conditional return of Promises, where applicable.

It works for the labels but it does not work at all for doValidation which is basically the core validation routine, without making it all async.

I therefore will go down the path of making it fully async. Any objections please add here.

@jankapunkt Any updates on this async computations?

@jankapunkt
Copy link
Member Author

@aashutoshshr I got stuck by serut/meteor-coverage#95 which blocks most of my conributions right now, since without decent coverage it's really time-consuming and stressful to migrate/refactor code.

@jankapunkt
Copy link
Member Author

jankapunkt commented Aug 21, 2024

@StorytellerCZ I released a 2.0.0 as of today. It's stable in what it does and resolved the correct 2x/3x versions dependencies. Regarding async compatibility: we should make a vote

@igorwas
Copy link

igorwas commented Oct 9, 2024

@jankapunkt any updates when this can be released?

@jankapunkt jankapunkt merged commit bca6908 into master Nov 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update autoValue to accept async function
5 participants