-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to Meteor 3.0 #150
Conversation
jankapunkt
commented
Jan 4, 2024
•
edited
Loading
edited
- updated package versions
- test project with 3.0
- self-tests running
- CI to GitHub actions
The changes so far are good. 👍 |
I'm not sure where to put issues for this, but I was trying this out to get my Meteor 3.0 tested and for the client unit tests it seems unable to run any of my tests
It will print out the "Group started" but never the "test started" and then it will just hang. I am running into other problems with my integration tests, but I haven't figured out if its this package or puppeteer causing the issue. |
@ToyboxZach please create a new issue and link this PR. Please add some info for reproduction or link a minimal reproduction repo. I'll take a look at it. |
Note that it's likely an issue with it.only as we upgraded to mocha v 10. |
It has nothing to do with only. Nothing works, even in the most basic case: |
published
|
@StorytellerCZ can you please remove this project from circleCI or do we need to contact someone else for that? |
Removed the hook in the settings. We no longer have any integration set for this and I think the settings file is also gone, so hopefully that check will be gone in next push. |
Fixed the version @jankapunkt, I think this is ready for release now. |
@StorytellerCZ yes it was working well with the previous RC packages so you can release, please also add review so I can merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is hard to see what was changed, since it included many formatting changes as part of this PR. Anyway, looks good.
Just publish version 3.0.0 for this package #155 |
Version 3.0.0 is published!
Why is there also version 3.0.3? |