Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to Meteor 3.0 #150

Merged
merged 23 commits into from
Jul 29, 2024
Merged

Migration to Meteor 3.0 #150

merged 23 commits into from
Jul 29, 2024

Conversation

jankapunkt
Copy link
Member

@jankapunkt jankapunkt commented Jan 4, 2024

  • updated package versions
  • test project with 3.0
  • self-tests running
  • CI to GitHub actions

@harryadel
Copy link
Member

The changes so far are good. 👍

@ToyboxZach
Copy link

I'm not sure where to put issues for this, but I was trying this out to get my Meteor 3.0 tested and for the client unit tests it seems unable to run any of my tests


describe.only("My group", () => {
  console.log("Group started);

  it.only("My test", () => {
    console.log("Test started");

It will print out the "Group started" but never the "test started" and then it will just hang.

I am running into other problems with my integration tests, but I haven't figured out if its this package or puppeteer causing the issue.

@jankapunkt
Copy link
Member Author

@ToyboxZach please create a new issue and link this PR. Please add some info for reproduction or link a minimal reproduction repo. I'll take a look at it.

@jankapunkt
Copy link
Member Author

Note that it's likely an issue with it.only as we upgraded to mocha v 10.

@ToyboxZach
Copy link

It has nothing to do with only. Nothing works, even in the most basic case:

#151

@jankapunkt
Copy link
Member Author

published 3.1.0-rc.0 @ToyboxZach @StorytellerCZ

  • fixed back-compat with 2.x in mocha-core
  • upgraded versionsFrom towards 2.8.0 and 3.0-rc.2
  • upgrade browser-tests versionsFrom

@jankapunkt
Copy link
Member Author

@StorytellerCZ can you please remove this project from circleCI or do we need to contact someone else for that?

@jankapunkt jankapunkt changed the title prepare first 3.0 compatible release Migration to Meteor 3.0 Jun 11, 2024
@StorytellerCZ
Copy link
Member

Removed the hook in the settings. We no longer have any integration set for this and I think the settings file is also gone, so hopefully that check will be gone in next push.

@StorytellerCZ
Copy link
Member

Fixed the version @jankapunkt, I think this is ready for release now.

@jankapunkt
Copy link
Member Author

@StorytellerCZ yes it was working well with the previous RC packages so you can release, please also add review so I can merge

Copy link
Member

@nachocodoner nachocodoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is hard to see what was changed, since it included many formatting changes as part of this PR. Anyway, looks good.

@denihs
Copy link
Contributor

denihs commented Jul 18, 2024

Just publish version 3.0.0 for this package #155

Version 3.0.0 is published!
@StorytellerCZ
Copy link
Member

Why is there also version 3.0.3?

@StorytellerCZ StorytellerCZ merged commit a7cc068 into master Jul 29, 2024
2 checks passed
@StorytellerCZ StorytellerCZ deleted the migrate/3.0 branch July 29, 2024 11:54
@jankapunkt jankapunkt linked an issue Aug 7, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move tests from CI to GitHub actions
6 participants