Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Workflow #21

Merged
merged 18 commits into from
Jul 21, 2023

Conversation

harryadel
Copy link
Member

@harryadel harryadel commented Jul 21, 2023

I had tried to do the Electron 14 upgrade, but it turns out that it's a much bigger endeavor than I had initially hoped for.

I couldn't go forward with the updates as the integration tests were failing and upon further inspection, I found out https://github.com/electron-userland/spectron is deprecated. I tried multiple workarounds like bringing the electron and spectron versions in sync as they require specific version to work with each other but to no avail. I even removed all of the changes and simply ran the CI and it failed which makes we wonder if it was even passing before!

I'm cornered into thinking that a re-write to https://webdriver.io/docs/wdio-electron-service/ or https://github.com/microsoft/playwright is the way to go. Which isn't a simple task, at least for me. 🤷‍♂️
Although, the electron version update is a pressing matter there're much bigger underlying problems that needs to be attended to first.

Sadly, time has ran out for me and I've to go back to you know where 🪖 So, I'll leave this here and hopefully someone else can pick up the slack. Till next vacation, bye! 👋

@harryadel harryadel marked this pull request as ready for review July 21, 2023 08:27
@StorytellerCZ
Copy link
Member

Hi @harryadel

Thank you for giving this a try. Looking back I think I have reached similar conclusion as you. I think I will look into building something with the newer tools and possibly GroundDB in the future once I reach the point of need for my projects.

@StorytellerCZ StorytellerCZ merged commit d88a3e1 into Meteor-Community-Packages:master Jul 21, 2023
@a4xrbj1
Copy link

a4xrbj1 commented Jul 21, 2023

@harryadel - thanks for helping out, appreciated

@StorytellerCZ - Jan, will this lead to a new version? If so, then I can try it out with my app to build a new version. Thanks!

@StorytellerCZ
Copy link
Member

This is Github workflow so this won't lead to new version. It only makes it easier to run tests here on Github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants