Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm packages in the ".meteor/desktop-build" folder are outdated #31

Closed
a4xrbj1 opened this issue Oct 4, 2023 · 6 comments
Closed

npm packages in the ".meteor/desktop-build" folder are outdated #31

a4xrbj1 opened this issue Oct 4, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@a4xrbj1
Copy link

a4xrbj1 commented Oct 4, 2023

The following npm packages in the .meteor\desktop-build folder are outdated:

Patch Update Backwards-compatible bug fixes.
❯◯ lodash 4.17.15 ❯ 4.17.21 https://lodash.com/
◯ request 2.88.0 ❯ 2.88.2 https://github.com/request/request#readme
◯ request-promise 4.2.5 ❯ 4.2.6 https://github.com/request/request-promise#readme

Minor Update New backwards-compatible features.
◯ connect 3.6.6 ❯ 3.7.0 https://github.com/senchalabs/connect#readme

Major Update Potentially breaking API changes. Use caution.
◯ winston 2.3.0 ❯ 3.10.0 https://github.com/winstonjs/winston#readme
◯ find-port 2.0.1 ❯ 3.0.0 https://github.com/kessler/find-port#readme
◯ rimraf 2.6.2 ❯ 5.0.5 https://github.com/isaacs/rimraf#readme
◯ queue 4.0.1 ❯ 7.0.0 https://github.com/jessetane/queue#readme
◯ mime 2.0.3 ❯ 3.0.0 https://github.com/broofa/mime#readme
◯ fs-extra 3.0.1 ❯ 11.1.1 https://github.com/jprichardson/node-fs-extra
◯ fs-plus 2.9.3 ❯ 3.1.1 http://atom.github.io/fs-plus
◯ electron-updater 5.0.5 ❯ 6.1.4 https://github.com/electron-userland/electron-builder

Non-Semver Versions less than 1.0.0, caution.
◯ shelljs 0.7.5 ❯ 0.8.5 http://github.com/shelljs/shelljs
◯ reify 0.17.3 ❯ 0.20.12 https://github.com/benjamn/reify#readme
◯ send 0.16.2 ❯ 0.18.0 https://github.com/pillarjs/send#readme

Steps to reproduce the behavior:

  1. Go to .meteor\desktop-build folder
  2. Run npm-check -u (or similar) to see which packages are outdated

Expected behavior

No outdated npm packages

Versions (please complete the following information):

  • Meteor version: 2.12.0
  • Package version: 3.0.1
@a4xrbj1 a4xrbj1 added the bug Something isn't working label Oct 4, 2023
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Thank you for submitting this issue!

We, the Members of Meteor Community Packages take every issue seriously.
Our goal is to provide long-term lifecycles for packages and keep up
with the newest changes in Meteor and the overall NodeJs/JavaScript ecosystem.

However, we contribute to these packages mostly in our free time.
Therefore, we can't guarantee your issues to be solved within certain time.

If you think this issue is trivial to solve, don't hesitate to submit
a pull request, too! We will accompany you in the process with reviews and hints
on how to get development set up.

Please also consider sponsoring the maintainers of the package.
If you don't know who is currently maintaining this package, just leave a comment
and we'll let you know

@StorytellerCZ
Copy link
Member

We will have to split it further as some packages will need complete replacement like request. I will have a PR for few of them shortly.

a4xrbj1 added a commit that referenced this issue Oct 4, 2023
…skeleton-dendencies

Update skeleton dependencies patch and some feature releases #31
@dd137
Copy link

dd137 commented Oct 18, 2023

@a4xrbj1 Would you mind updating the OP's list with the packages Jan has updated already (893931f)?

It would be great if you tried updating the other packages too. Then we could include that in a v3.1.2? (IMHO 3.1.1 is ready for release and could be published from 3.1.1-rc.2)

@a4xrbj1
Copy link
Author

a4xrbj1 commented Oct 18, 2023

All are working except Winston:

npm ERR! code ETARGET
npm ERR! notarget No matching version found for [email protected].
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.

@jankapunkt - can you please use a version that exists and is compatible to the current NPM version that Meteor uses?

@dd137
Copy link

dd137 commented Oct 18, 2023

All are working

Do you mean that you updated all dependencies as per the original post and everything runs fine? That's great. Are you planning to create a PR?

except Winston:

I have already fixed the Winston issue (51f973b) (without major version bump), it should be fine since rc.1.

@StorytellerCZ
Copy link
Member

Closing this as some were already updated and other are being updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants